ports/143683: git depends on iconv even when ICONV option not selected

[Stef Walter]

>Number:         143683
>Category:       ports
>Synopsis:       git depends on iconv even when ICONV option not selected
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Feb 08 23:00:10 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Stef Walter
>Release:        7.2-RELEASE
>Organization:
>Environment:
FreeBSD 7orient.ws.local 7.2-RELEASE FreeBSD 7.2-RELEASE-p4 #2: Sat Oct  3 02:36:12 UTC 2009     root at dev-test2.ws.local:/usr/obj/usr/src/sys/DEVTEST2  amd64

>Description:
Recent versions of git started depending on libiconv, even when the ICON build option is not selected. For example git-1.6.6.1

This is because the git Makefile sets NEEDS_LIBICONV if uname contains FreeBSD.
>How-To-Repeat:
Build devel/git port without the ICONV option. Then:

$ ldd /usr/local/bin/git
>Fix:
Attaching a patch

Patch attached with submission follows:

--- ./Makefile.orig	2010-02-08 22:42:55.000000000 +0000
+++ ./Makefile	2010-02-08 22:43:15.000000000 +0000
@@ -824,5 +824,4 @@
 endif
 ifeq ($(uname_S),FreeBSD)
-	NEEDS_LIBICONV = YesPlease
 	OLD_ICONV = YesPlease
 	NO_MEMMEM = YesPlease


>Release-Note:
>Audit-Trail:
>Unformatted: