ports/153033: un-escaped shell metacharacters in bsd.port.subdir.mk

[Steve Price]

>Number:         153033
>Category:       ports
>Synopsis:       un-escaped shell metacharacters in bsd.port.subdir.mk
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Dec 11 23:50:09 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Steve Price
>Release:        8.1-RELEASE
>Organization:
>Environment:
FreeBSD host14.warningsystems.com 8.1-RELEASE FreeBSD 8.1-RELEASE #2: Fri Aug 13 11:14:49 CDT 2010     steve at host14.warningsystems.com:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
There's an issue in bsd.port.subdir.mk where un-escaped shell
metacharacters are causing the build of the automake14 port to
fail.
>How-To-Repeat:
Create the following Makefile and 'make all'.

---8<---
#USE_JAVA=yes

all clean:
        cd /usr/ports/devel/automake14 && make $@

foobar:
        @echo "_JAVA_VERSION_LIST_REGEXP=${_JAVA_VERSION_LIST_REGEXP}"
        @echo "_JAVA_VENDOR_LIST_REGEXP=${_JAVA_VENDOR_LIST_REGEXP}"
        @echo "_JAVA_OS_LIST_REGEXP=${_JAVA_OS_LIST_REGEXP}"

.if defined(USE_JAVA)
.include <bsd.port.mk>
.else
.include <bsd.port.subdir.mk>
.endif
----8<---
>Fix:
--- bsd.port.subdir.mk.orig	2010-12-11 15:36:38.000000000 -0600
+++ bsd.port.subdir.mk	2010-12-11 15:34:12.000000000 -0600
@@ -377,9 +377,9 @@
 	PYTHON_DEFAULT_VERSION="${PYTHON_DEFAULT_VERSION}" \
 	PYTHON_DEFAULT_PORTVERSION="${PYTHON_DEFAULT_PORTVERSION}" \
 	PYTHONBASE="${PYTHONBASE}" \
-	_JAVA_VERSION_LIST_REGEXP="${_JAVA_VERSION_LIST_REGEXP}" \
-	_JAVA_VENDOR_LIST_REGEXP="${_JAVA_VENDOR_LIST_REGEXP}" \
-	_JAVA_OS_LIST_REGEXP="${_JAVA_OS_LIST_REGEXP}" \
+	_JAVA_VERSION_LIST_REGEXP="${_JAVA_VERSION_LIST_REGEXP:Q}" \
+	_JAVA_VENDOR_LIST_REGEXP="${_JAVA_VENDOR_LIST_REGEXP:Q}" \
+	_JAVA_OS_LIST_REGEXP="${_JAVA_OS_LIST_REGEXP:Q}" \
 	_JAVA_PORTS_INSTALLED="${_JAVA_PORTS_INSTALLED}"
 .endif


>Release-Note:
>Audit-Trail:
>Unformatted: