ports/153019: net/samba-smbclient: Allow SAMBA_PORT to be set via /etc/make.conf

Sat Dec 11 16:10:10 UTC 2010

>Number:         153019
>Category:       ports
>Synopsis:       net/samba-smbclient: Allow SAMBA_PORT to be set via /etc/make.conf
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Dec 11 16:10:10 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Hartmann, O.
>Release:        FreeBSD 8/9
>Organization:
FU Berlin
>Environment:
>Description:
Makefile of port net/samba-libsmbclient sets explicitely SAMBA_PORT= samba34, even if maintainer of the box already has installed samba35 or made a setup by setting SAMBA_PORT= samba35 in /etc/make.conf.

It would be of great support if the maintainer could change Makefile this way:

replace SAMBA_PORT = samba34

by

SAMBA_PORT?= samba35

respecting a previous set SAMBA_PORT. I use it this way without problems. My standard SAMBA installation is samba35, not samba34, so I don't want a port to override this without any good reason.
>How-To-Repeat:

>Fix:
Replace line SAMBA_PORT= samba34 by SAMBA_PORT?= samba34 in port's Makefile located in net/samba-libsmbclient.

>Release-Note:
>Audit-Trail:
>Unformatted: