ports/152886: databases/py-bsddb fails to build with databases/db51

[Anatoly Borodin]

>Number:         152886
>Category:       ports
>Synopsis:       databases/py-bsddb fails to build with databases/db51
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Dec 07 12:20:04 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Anatoly Borodin
>Release:        
>Organization:
>Environment:
>Description:
The constants like DB_XIDDATASIZE were renamed in db51 or earlier releases.

I don't know if I could use databases/py-bsddb3 instead, but databases/py-bsddb is being used by a dozen of other ports.
>How-To-Repeat:
# cd /usr/ports/databases/py-bsddb && make
===>  License check disabled, port has not defined LICENSE
===>  Extracting for py26-bsddb-2.6.6_2
=> SHA256 Checksum OK for python/Python-2.6.6.tgz.
===>  Patching for py26-bsddb-2.6.6_2
/usr/bin/sed -i.bak -e  's,^\(#include.*\)\(db\.h.*\)$,\1/usr/local/include/db51/\2,'  /usr/obj/usr/ports/databases/py-bsddb/work/Python-2.6.6/Modules/bsddb.h
===>   py26-bsddb-2.6.6_2 depends on file: /usr/local/bin/python2.6 - found
===>   py26-bsddb-2.6.6_2 depends on shared library: db-5.1.0 - found
===>  Configuring for py26-bsddb-2.6.6_2
running config
===>  Building for py26-bsddb-2.6.6_2
running build
running build_ext
building '_bsddb' extension
creating build
creating build/temp.freebsd-8.1-STABLE-i386-2.6
cc -DNDEBUG -O2 -pipe -march=native -D__wchar_t=wchar_t -DTHREAD_STACK_SIZE=0x100000 -fno-strict-aliasing -O2 -pipe -march=native -fno-strict-aliasing -fPIC -I/usr/local/include -I/usr/local/include/python2.6 -c _bsddb.c -o build/temp.freebsd-8.1-STABLE-i386-2.6/_bsddb.o
_bsddb.c: In function 'DBEnv_txn_recover':
_bsddb.c:4514: warning: passing argument 4 of 'self->db_env->txn_recover' from incompatible pointer type
_bsddb.c:4525: error: 'DB_XIDDATASIZE' undeclared (first use in this function)
_bsddb.c:4525: error: (Each undeclared identifier is reported only once
_bsddb.c:4525: error: for each function it appears in.)
_bsddb.c: In function 'DBEnv_set_rpc_server':
_bsddb.c:5065: error: 'DB_ENV' has no member named 'set_rpc_server'
_bsddb.c: In function 'DBTxn_prepare':
_bsddb.c:5952: error: 'DB_XIDDATASIZE' undeclared (first use in this function)
_bsddb.c: In function 'init_bsddb':
_bsddb.c:7095: error: 'DB_RPCCLIENT' undeclared (first use in this function)
_bsddb.c:7101: error: 'DB_XA_CREATE' undeclared (first use in this function)
_bsddb.c:7118: error: 'DB_XIDDATASIZE' undeclared (first use in this function)
error: command 'cc' failed with exit status 1
*** Error code 1

Stop in /usr/ports/databases/py-bsddb.

>Fix:
The old constant names should be patched, but the logic should be checked too.

>Release-Note:
>Audit-Trail:
>Unformatted: