ports/149805: [patch] let sysutils/brasero recognize cdrecord version properly
Kuan-Chung Chiu
buganini at gmail.com
Thu Aug 19 14:20:01 UTC 2010
>Number: 149805
>Category: ports
>Synopsis: [patch] let sysutils/brasero recognize cdrecord version properly
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Thu Aug 19 14:20:00 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator: Kuan-Chung Chiu
>Release: 9.0-CURRENT
>Organization:
N/A
>Environment:
FreeBSD zeta.twbbs.org 9.0-CURRENT FreeBSD 9.0-CURRENT #3 r211326: Sun Aug 15 18:38:34 UTC 2010 root at zeta.twbbs.org:/usr/obj/usr/src/sys/ELIZABETH amd64
>Description:
With original source, brasero expect `cdrecord --version` return "Cdrecord-ProDVD-ProBD-Clone %d.%d" but it is actually "Cdrecord-Clone %d.%d"
>How-To-Repeat:
Try to burn a iso with brasero, it will ask you to install cdrecord, or see Edit->Plugins, there is a version too old message below cdrecord.
>Fix:
in cdrecord.c:
# define PRODVD_TITLE ""
#ifdef CLONE_WRITE
# define CLONE_TITLE "-Clone"
#else
# define CLONE_TITLE ""
#endif
if ((flags & F_MSINFO) == 0 || lverbose || flags & F_VERSION) {
printf("Cdrecord%s%s %s (%s-%s-%s) Copyright (C) 1995-2004 JM-vrg Schilling\n",
PRODVD_TITLE,
CLONE_TITLE,
cdr_version,
HOST_CPU, HOST_VENDOR, HOST_OS);
PRODVD_TITLE is always defined as "", so we can ignore it, as the patch attached,
but i'm not sure about the CLONE_TITLE.
Patch attached with submission follows:
diff -ruN brasero.orig/files/patch-plugins-cdrtools-burn-cdrecord.c brasero/files/patch-plugins-cdrtools-burn-cdrecord.c
--- brasero.orig/files/patch-plugins-cdrtools-burn-cdrecord.c 1970-01-01 00:00:00.000000000 +0000
+++ brasero/files/patch-plugins-cdrtools-burn-cdrecord.c 2010-08-19 21:57:42.000000000 +0000
@@ -0,0 +1,10 @@
+--- plugins/cdrtools/burn-cdrecord.c.orig 2010-08-19 21:55:26.000000000 +0000
++++ plugins/cdrtools/burn-cdrecord.c 2010-08-19 21:55:50.000000000 +0000
+@@ -1442,6 +1442,6 @@
+ brasero_plugin_test_app (plugin,
+ "cdrecord",
+ "--version",
+- "Cdrecord-ProDVD-ProBD-Clone %d.%d",
++ "Cdrecord-Clone %d.%d",
+ version);
+ }
>Release-Note:
>Audit-Trail:
>Unformatted:
More information about the freebsd-ports-bugs
mailing list