ports/133146: [patch] x11-fonts/dejavu: install fontconfig configuration files to conf.avail and optionally links to conf.d

[Anonymous]

The following reply was made to PR ports/133146; it has been noted by GNATS.

From: Anonymous <swell.k at gmail.com>
To: Sunpoet Hsieh <sunpoet at sunpoet.net>
Cc: bug-followup at freebsd.org
Subject: Re: ports/133146: [patch] x11-fonts/dejavu: install fontconfig  configuration files to conf.avail and optionally links to conf.d
Date: Sun, 08 Aug 2010 19:44:33 +0400

 Sunpoet Hsieh <sunpoet at sunpoet.net> writes:
 
 > Hi,
 >
 > Based on your patch, a fix with minor modification is attached.
 > Thanks.
 
 A fix for what? For useless renaming[1]. It already works fine. Besides,
 your patch is malformed by line-wrapping.
 
   $ cd x11-font/dejavu
   $ patch -CEfsp5 -i ~/dejavu.patch
   patch: **** malformed patch at line 57: 18:49:50 sylvio Exp $
 
 > +.if defined(WITH_LINKS)
 > +FCDIR_LINKS=	${FCDIR_REL:S|conf.avail|conf.d|}
 > +PLIST_SUB+=	FCDIR_LINKS="${FCDIR_LINKS}"
 > +.else
 > +PLIST_SUB+=	FCDIR_LINKS="@comment "
 > +.endif
 > +
 >  do-install:
 > -	@${MKDIR} ${FONTSDIR}
 > -	@${INSTALL_DATA} ${WRKSRC}/ttf/*.ttf ${FONTSDIR}
 
 > +	${MKDIR} ${FCDIR} ${PREFIX}/${FCDIR_LINKS}
 
 You don't have to create FCDIR. It should be done by fontconfig port[2].
 Many japanese/font-* ports maintained by hrs@ don't create fonts/conf.d, too.
 BTW, FCDIR_LINKS would be empty in WITHOUT_LINKS case.
 
 So, while I don't agree with your changes you're free to ignore me as
 the maintainer of this port.
 
 [1] _REL suffix is not used in label names in plist substitution in bsd.port.mk.
     And FCDIR_LINKS doesn't make it any more clear to what directory it's
     referred. fonts/conf.d can contain actual files, not only links.
 
 [2] fonts/conf.{avail,d} should probably be put to MTREE_FILE,
     they're same as share/emacs/site-lisp, i.e. expected to be present
     even when the app using them is not installed or installed under
     different PREFIX