ports/146101: kdm does not work with users who use KSH

[Jim Pirzyk]

>Number:         146101
>Category:       ports
>Synopsis:       kdm does not work with users who use KSH
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Apr 27 23:50:00 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Jim Pirzyk
>Release:        FreeBSD-8.0-RELEASE-p2
>Organization:
>Environment:
FreeBSD pcbsd.home.pirzyk.org 8.0-RELEASE-p2 FreeBSD 8.0-RELEASE-p2 #4: Thu Jan  7 09:20:42 PST 2010     root at build8x32.pcbsd.org:/usr/obj/usr/pcbsd-build80/fbsd-source/8.0-src/sys/PCBSD  i386
>Description:
If a user has KSH specific commands in their $HOME/.profile and sourcing (. $HOME/.profile) the file causes an error, the user will not be able to login via kdm.
>How-To-Repeat:
Create a user that uses ksh/pdksh and put KSH specific commands into the $HOME/.profile.  Try to login via kdm
>Fix:
Patching /usr/local/kde4/share/config/kdm/Xsession with the given patch solves the problem, but because Xsession is not part of the kdebase-workspace-4.3.5 package, the bin/genkdmconf command needs to be patched.

Patch attached with submission follows:

--- Xsession.orig	2010-04-27 13:32:09.000000000 -0400
+++ Xsession	2010-04-27 14:06:25.000000000 -0400
@@ -36,7 +36,13 @@
     . $xsess_tmp
     rm -f $xsess_tmp
     ;;
-  *) # Plain sh, ksh, and anything we do not know.
+  */ksh)
+    # KSH_VERSION is only defined by pdksh and not the ATT ksh.
+    [ -z "$RANDOM" ] && exec $SHELL $0 "$@"
+    [ -f /etc/profile ] && . /etc/profile
+    [ -f $HOME/.profile ] && . $HOME/.profile
+    ;;
+  *) # Plain sh, and anything we do not know.
     [ -f /etc/profile ] && . /etc/profile
     [ -f $HOME/.profile ] && . $HOME/.profile
     ;;


>Release-Note:
>Audit-Trail:
>Unformatted: