ports/145769: final link of mail/fetchmail fails libhx509.so undefined reference to MD2_Init etc

[Andrew Reilly]

The following reply was made to PR ports/145769; it has been noted by GNATS.

From: Andrew Reilly <areilly at bigpond.net.au>
To: bug-followup at FreeBSD.org
Cc:  
Subject: Re: ports/145769: final link of mail/fetchmail fails libhx509.so undefined reference to MD2_Init etc
Date: Mon, 26 Apr 2010 12:51:13 +1000

 --Apple-Mail-42--262185842
 Content-Transfer-Encoding: quoted-printable
 Content-Type: text/plain;
 	charset=us-ascii
 
 It is possible that fetchmail isn't failing for everyone because the =
 broken dependency only occurs when the GSSAPI option is enabled, which I =
 have.
 
 It seems that the (obsolete) MD2 functionality was not completely =
 expunged from the crypto libs in -CURRENT.  The attached patch is =
 probably a bit extreme, but I don't know enough about the crypto =
 framework to know what the 'right' answer is.  In any case, this is =
 sufficient to make the fetchmail build happy.
 
 Synopsis: remove *all* reference to MD2_* from the libhx509 crypto =
 library, so that it doesn't have dangling unsatisfied symbols in its =
 symbol table.
 
 
 --Apple-Mail-42--262185842
 Content-Disposition: attachment;
 	filename=hx509.patch
 Content-Type: application/octet-stream;
 	name="hx509.patch"
 Content-Transfer-Encoding: 7bit
 
 --- crypto.c	2008-05-07 23:39:29.000000000 +1000
 +++ crypto.c.md2expunged	2010-04-26 12:27:15.000000000 +1000
 @@ -841,6 +841,7 @@
      return 0;
  }
  
 +#if 0
  static int
  md2_verify_signature(hx509_context context,
  		     const struct signature_alg *sig_alg,
 @@ -870,6 +871,7 @@
  
      return 0;
  }
 +#endif /* 0 */
  
  static const struct signature_alg heim_rsa_pkcs1_x509 = {
      "rsa-pkcs1-x509",
 @@ -980,6 +982,7 @@
      md5_verify_signature
  };
  
 +#if 0
  static const struct signature_alg md2_alg = {
      "rsa-md2",
      oid_id_rsa_digest_md2,
 @@ -989,6 +992,7 @@
      SIG_DIGEST,
      md2_verify_signature
  };
 +#endif
  
  /* 
   * Order matter in this structure, "best" first for each "key
 @@ -1006,7 +1010,9 @@
      &sha256_alg,
      &sha1_alg,
      &md5_alg,
 +#if 0
      &md2_alg,
 +#endif
      NULL
  };
  
 
 --Apple-Mail-42--262185842--