ports/145955: make fetch-required-list in a port repeatedly lists the port's own source files

[Martin Simmons]

>Number:         145955
>Category:       ports
>Synopsis:       make fetch-required-list in a port repeatedly lists the port's own source files
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Apr 22 19:20:03 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Martin Simmons
>Release:        8.0-RELEASE-p2
>Organization:
>Environment:
FreeBSD lwfs100-cam.cam.lispworks.com 8.0-RELEASE-p2 FreeBSD 8.0-RELEASE-p2 #0: Tue Jan  5 21:11:58 UTC 2010     root at amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
Running make fetch-required-list in any port lists the source files for that port under every port that it depends on, rather than the source files for the dependent.

>How-To-Repeat:
On a system without imake installed:

cd /usr/ports/emulators/xzx
make fetch-required-list

It lists xzx-pro-4.6.tar.gz as the source file for devel/imake.

>Fix:
There is a spurious echo before a cd command in the FETCH_LIST macro in /usr/ports/Mk/bsd.port.mk, which causes it to run each dependent's make in the initial port's own directory instead of the dependent's directory.

See attached file no-echo.patch.


Patch attached with submission follows:

--- /usr/ports/Mk/bsd.port.mk.orig	2010-04-22 20:12:33.656348000 +0100
+++ /usr/ports/Mk/bsd.port.mk	2010-04-22 20:13:05.310417269 +0100
@@ -5295,7 +5295,7 @@
 				continue;	\
 			fi;;	\
 		esac;	\
-		echo cd $$dir; ${MAKE} $$targ; \
+		cd $$dir; ${MAKE} $$targ; \
 	done
 
 .if !target(fetch-required)


>Release-Note:
>Audit-Trail:
>Unformatted: