ports/144718: [PATCH] audio/libmp3splt: update to 0.5.9, fix build when WITHOUT_NLS is defined

Thu Apr 22 11:00:14 UTC 2010

The following reply was made to PR ports/144718; it has been noted by GNATS.

From: Sunpoet Po-Chuan Hsieh <sunpoet at sunpoet.net>
To: Anton Yuzhaninov <citrin at citrin.ru>
Cc: bug-followup at FreeBSD.org
Subject: Re: ports/144718: [PATCH] audio/libmp3splt: update to 0.5.9, fix
 build when WITHOUT_NLS is defined
Date: Thu, 22 Apr 2010 18:51:12 +0800

 Hi,

 Please use this patch with the one in PR/144719.
 This patch is for the build of both libmp3splt and mp3splt with WITHOUT_NLS defined.
 The reason is that libiconv-related functions are not well wrapped in ifdef conditions.
 Indeed, libmp3splt can be built without error when WITHOUT_NLS is defined.
 But it affects the build of mp3splt.
 As mp3splt depends on libmp3splt, it links against libmp3splt.so which refers
 to libintl_bindtextdomain, libintl_dgettext and libintl_bind_textdomain_codeset.
 However, these libintl_* should be UNKNOWN references since we have WITHOUT_NLS.

 Say that we are compiling libmp3splt 0.59 and mp3splt 2.2.8 with WITHOUT_NLS defined.
 Before applying the patches of PR/144718 (libmp3splt) and PR/144719 (mp3splt).
 While building mp3splt, we got error messages as follows:

 ===>  Building for mp3splt-2.2.8
 make  all-recursive
 Making all in src
 cc -DLOCALEDIR=\"/usr/local/share/locale\" -DHAVE_CONFIG_H -I. -I..    -O2 -pipe -s -mmmx -msse -msse2 -msse3 -march=nocona -mtune=nocona -I/usr/local/include  -Wall -O2 -O2 -pipe -s -mmmx -msse -msse2 -msse3 -march=nocona -mtune=nocona -march=nocona -fno-strict-aliasing -I../libmp3splt/include -I../../libmp3splt/include -MT mp3splt.o -MD -MP -MF .deps/mp3splt.Tpo -c -o mp3splt.o mp3splt.c
 mv -f .deps/mp3splt.Tpo .deps/mp3splt.Po
 cc  -Wall -O2 -O2 -pipe -s -mmmx -msse -msse2 -msse3 -march=nocona -mtune=nocona -march=nocona -fno-strict-aliasing -I../libmp3splt/include -I../../libmp3splt/include  -L/usr/local/lib -L../libmp3splt/src/.libs -L../../libmp3splt/src/.libs -o mp3splt mp3splt.o -L/usr/local/lib -lmp3splt
 mp3splt.o(.text+0x1c7): In function `print_no_warranty':
 : undefined reference to `libintl_gettext'
 mp3splt.o(.text+0x24d): In function `put_split_file':
 : undefined reference to `libintl_gettext'
 mp3splt.o(.text+0x28e): In function `print_error':
 : undefined reference to `libintl_gettext'
 mp3splt.o(.text+0x2bd): In function `print_warning':
 : undefined reference to `libintl_gettext'
 mp3splt.o(.text+0x48f): In function `put_progress_bar':
 : undefined reference to `libintl_gettext'
 mp3splt.o(.text+0x4ff): more undefined references to `libintl_gettext' follow
 mp3splt.o(.text+0x2542): In function `main':
 : undefined reference to `libintl_textdomain'
 mp3splt.o(.text+0x2591): In function `main':
 : undefined reference to `libintl_bindtextdomain'
 mp3splt.o(.text+0x25a0): In function `main':
 : undefined reference to `libintl_bind_textdomain_codeset'
 mp3splt.o(.text+0x2687): In function `main':
 : undefined reference to `libintl_gettext'
 mp3splt.o(.text+0x29d3): In function `main':
 : undefined reference to `libintl_gettext'
 mp3splt.o(.text+0x2d4a): In function `main':
 : undefined reference to `libintl_gettext'
 mp3splt.o(.text+0x2e72): In function `main':
 : undefined reference to `libintl_gettext'
 mp3splt.o(.text+0x2f5b): In function `main':
 : undefined reference to `libintl_gettext'
 mp3splt.o(.text+0x3436): more undefined references to `libintl_gettext' follow
 /usr/local/lib/libmp3splt.so: undefined reference to `libintl_dgettext'
 *** Error code 1

 Stop in /usr/ports/works/usr/ports/sunpoet/mp3splt/work/mp3splt-2.2.8/src.
 *** Error code 1

 Stop in /usr/ports/works/usr/ports/sunpoet/mp3splt/work/mp3splt-2.2.8.
 *** Error code 1

 Stop in /usr/ports/sunpoet/mp3splt.

 Now we apply the patch in PR/144719 (mp3splt). The error messages look like:

 ===>  Building for mp3splt-2.2.8
 make  all-recursive
 Making all in src
 cc -DLOCALEDIR=\"/usr/local/share/locale\" -DHAVE_CONFIG_H -I. -I..    -O2 -pipe -s -mmmx -msse -msse2 -msse3 -march=nocona -mtune=nocona -I/usr/local/include  -Wall -O2 -O2 -pipe -s -mmmx -msse -msse2 -msse3 -march=nocona -mtune=nocona -march=nocona -fno-strict-aliasing -I../libmp3splt/include -I../../libmp3splt/include -MT mp3splt.o -MD -MP -MF .deps/mp3splt.Tpo -c -o mp3splt.o mp3splt.c
 mv -f .deps/mp3splt.Tpo .deps/mp3splt.Po
 cc  -Wall -O2 -O2 -pipe -s -mmmx -msse -msse2 -msse3 -march=nocona -mtune=nocona -march=nocona -fno-strict-aliasing -I../libmp3splt/include -I../../libmp3splt/include  -L/usr/local/lib -L../libmp3splt/src/.libs -L../../libmp3splt/src/.libs -o mp3splt mp3splt.o -L/usr/local/lib -lmp3splt
 /usr/local/lib/libmp3splt.so: undefined reference to `libintl_bindtextdomain'
 /usr/local/lib/libmp3splt.so: undefined reference to `libintl_dgettext'
 /usr/local/lib/libmp3splt.so: undefined reference to `libintl_bind_textdomain_codeset'
 *** Error code 1

 Stop in /usr/ports/works/usr/ports/sunpoet/mp3splt/work/mp3splt-2.2.8/src.
 *** Error code 1

 Stop in /usr/ports/works/usr/ports/sunpoet/mp3splt/work/mp3splt-2.2.8.
 *** Error code 1

 Stop in /usr/ports/sunpoet/mp3splt.

 At last, we apply two patches and everything works fine.

 BR,
 - Sunpoet

 On Thu, Apr 22, 2010 at 01:22:01AM +0400, Anton Yuzhaninov wrote:
 > I can build and libmp3splt 0.5.9 when WITHOUT_NLS is defined without suggested
 > patch.
 > 
 > Can you mail me full build log with error?
 > 
 > -- 
 >  Anton Yuzhaninov

 -- 
                               Sunpoet Po-Chuan Hsieh <sunpoet at sunpoet.net>