ports/145704: [patch] Update-request: audio/xmms2-scrobbler

[SimaMoto at FreeBSD.org]

>Number:         145704
>Category:       ports
>Synopsis:       [patch] Update-request: audio/xmms2-scrobbler
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Apr 14 16:10:06 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     SimaMoto,RyoTa
>Release:        8.0-RELEASE
>Organization:
>Environment:
System: FreeBSD takiba.net 8.0-RELEASE FreeBSD 8.0-RELEASE #0: Sat Nov 21 15:48:17 UTC 2009 root at almeida.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
The latest version of xmms2-scrobber is 0.4.0.  On the current version
of this port (0.1.3), this program will stop with some error messages
when a new track starts and the process is killed.

I made updating port in the attached patch:
 * add a more site
 * remove dependency on Ruby
 * modify personal configuration instruction at files/pkg-message.in,
   because its rule was changed
 * add README file as PORTDOC which contains more detailed instruction

And file/patch-aa is added for patching:
 * on Makefile which adds library link to -lpthread for pthread_create(3)

>How-To-Repeat:
Play any track by xmms2.
>Fix:
This patch file modifies
Makefile
distinfo
pkg-descr
file/pkg-message.in

Patch attached with submission follows:

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/audio/xmms2-scrobbler/Makefile,v
retrieving revision 1.11
diff -u -r1.11 Makefile
--- Makefile	19 Aug 2009 11:56:16 -0000	1.11
+++ Makefile	14 Apr 2010 15:51:19 -0000
@@ -2,39 +2,34 @@
 # Date created:				06 Apr 2006
 # Whom:					Alexander Botero-Lowry <alex at foxybanana.com>
 #
-# $FreeBSD: ports/audio/xmms2-scrobbler/Makefile,v 1.11 2009/08/19 11:56:16 miwi Exp $
+# $FreeBSD$
 
 PORTNAME=	xmms2-scrobbler
-PORTVERSION=	0.1.3
-PORTREVISION=	2
-CATEGORIES=	audio ruby
-MASTER_SITES=	http://exodus.xmms.se/~tilman/
+PORTVERSION=	0.4.0
+CATEGORIES=	audio
+MASTER_SITES=	http://ftp.code-monkey.de/pub/${PORTNAME}/ \
+	http://exodus.xmms.se/~tilman/
 
 MAINTAINER=	ports at FreeBSD.org
 COMMENT=	A last.fm submission client for XMMS2
 
-BUILD_DEPENDS=	${RUBY_SITEARCHLIBDIR}/xmmsclient_ext.so:${PORTSDIR}/audio/ruby-xmms2 \
-		${RUBY_SITELIBDIR}/event-loop.rb:${PORTSDIR}/devel/ruby-event-loop
-RUN_DEPENDS=	${RUBY_SITEARCHLIBDIR}/xmmsclient_ext.so:${PORTSDIR}/audio/ruby-xmms2 \
-		${RUBY_SITELIBDIR}/event-loop.rb:${PORTSDIR}/devel/ruby-event-loop
-
-USE_RUBY=	yes
-USE_RAKE=	yes
-NO_BUILD=	yes
-
-PLIST_FILES=	bin/xmms2-scrobbler \
-		%%DATADIR%%/filters/britney.rb \
-		%%DATADIR%%/filters/musicbrainz.rb
-PLIST_DIRS=	%%DATADIR%%/filters %%DATADIR%%
+LIB_DEPENDS=	xmmsclient.5:${PORTSDIR}/audio/xmms2 \
+		curl.6:${PORTSDIR}/ftp/curl
 
-SUB_FILES=	pkg-message
+USE_GMAKE=	yes
+
+PLIST_FILES=	bin/xmms2-scrobbler
+PORTDOCS=	README
 
-do-install:
-	@cd ${WRKSRC} && ${RAKE_BIN} PREFIX=${PREFIX}/ ${INSTALL_TARGET}
+SUB_FILES=	pkg-message
 
 post-install:
 	@${ECHO_MSG}
 	@${CAT} ${PKGMESSAGE}
 	@${ECHO_MSG}
+.if !defined(NOPORTDOCS)
+	@${MKDIR} ${DOCSDIR}; \
+	cd ${WRKSRC} && ${INSTALL_MAN} ${PORTDOCS} ${DOCSDIR}
+.endif
 
 .include <bsd.port.mk>
Index: distinfo
===================================================================
RCS file: /home/ncvs/ports/audio/xmms2-scrobbler/distinfo,v
retrieving revision 1.3
diff -u -r1.3 distinfo
--- distinfo	27 May 2007 22:58:34 -0000	1.3
+++ distinfo	14 Apr 2010 15:51:19 -0000
@@ -1,3 +1,3 @@
-MD5 (xmms2-scrobbler-0.1.3.tar.gz) = 4d7fde80a5a6c963cf46864f2747d773
-SHA256 (xmms2-scrobbler-0.1.3.tar.gz) = 2c2306eedab88f3b8ee4b8ab07b84405349d35e0ce4a57e300f491f70049cf26
-SIZE (xmms2-scrobbler-0.1.3.tar.gz) = 6466
+MD5 (xmms2-scrobbler-0.4.0.tar.gz) = f5be15c90cf7c60209031b8968f77b19
+SHA256 (xmms2-scrobbler-0.4.0.tar.gz) = 7aed1670f381463e44466083f2e49119636e96005b9b93899edf79d613a2d2bc
+SIZE (xmms2-scrobbler-0.4.0.tar.gz) = 19831
Index: files/pkg-message.in
===================================================================
RCS file: /home/ncvs/ports/audio/xmms2-scrobbler/files/pkg-message.in,v
retrieving revision 1.2
diff -u -r1.2 pkg-message.in
--- files/pkg-message.in	23 Dec 2006 02:27:02 -0000	1.2
+++ files/pkg-message.in	14 Apr 2010 15:51:19 -0000
@@ -1,8 +1,24 @@
-To use XMMS2Scrobbler write your username and password to the config file
-like this:
+You need to set up XMMS2-Scrobbler's config files.
+Config values that are specific to the AudioScrobbler server go in
+	~/.config/xmms2/clients/xmms2-scrobbler/$SERVER_NAME/config.
+You will usually have
+	~/.config/xmms2/clients/xmms2-scrobbler/lastfm/config
+and maybe
+	~/.config/xmms2/clients/xmms2-scrobbler/librefm/config.
 
-        printf "user: foo\npassword: bar" > \
-                ~/.config/xmms2/clients/xmms2-scrobbler/config
+These server-specific config files contain your username and password
+and the URL to use:
+	mkdir ~/.config/xmms2/clients/xmms2-scrobbler/librefm/config
+	echo -e "user: foo\npassword: bar\nhandshake_url: http://post.audioscrobbler.com\n" > \
+	~/.config/xmms2/clients/xmms2-scrobbler/lastfm/config
+For libre.fm, use
+	handshake_url: http://turtle.libre.fm.
+
+Optionally, if you're behind a proxy, you'll need to tell XMMS2-Scrobbler
+about that proxy.  This information applies to all servers and so goes in
+~/.config/xmms2/clients/xmms2-scrobbler/config:
+	echo -e "proxy: my.proxynproxy_port: 8080\n" >> \
+	~/.config/xmms2/clients/xmms2-scrobbler/config
 
 ~/.config is actually $XDG_CONFIG_HOME whose default value is ~/.config.
 


>Release-Note:
>Audit-Trail:
>Unformatted: