ports/138943: security/openssh-portable version 5.2p1_2, 1 broke WITH_OVERWRITE_BASE

[Alson van der Meulen]

>Number:         138943
>Category:       ports
>Synopsis:       security/openssh-portable version 5.2p1_2,1 broke WITH_OVERWRITE_BASE
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Sep 18 18:10:01 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Alson van der Meulen
>Release:        FreeBSD 6.4-RELEASE-p3 i386
>Organization:
>Environment:
System: FreeBSD eraser.waalsdorp.nl 6.4-RELEASE-p3 FreeBSD 6.4-RELEASE-p3 #1: Sat Apr 11 08:27:26 CEST 2009 root at eraser.waalsdorp.nl:/usr/src/sys/i386/compile/ERASER i386
openssh-portable-overwrite-base-5.2.p1_2,1

>Description:
Installation of security/openssh-portable version 5.2p1_2,1 breaks if WITH_OVERWRITE_BASE is defined:
echo "===> Installing rc.d startup script(s)"
===> Installing rc.d startup script(s)
echo "@cwd /usr" >> /usr/ports/security/openssh-portable/work/.PLIST.mktmp
for i in openssh; do  install  -o root -g wheel -m 555 /usr/ports/security/opens
sh-portable/work/${i} /usr/etc/rc.d/${i%.sh};  echo "etc/rc.d/${i%.sh}" >> /usr/
ports/security/openssh-portable/work/.PLIST.mktmp;  done
install: /usr/etc/rc.d/openssh: No such file or directory
*** Error code 71

This is caused by this change:
@@ -182,8 +187,7 @@ CONFIGURE_ARGS+=	--localstatedir=/var
 EMPTYDIR=		/var/empty
 PREFIX=			/usr
 ETCSSH=			/etc/ssh
-USE_RC_SUBR=		yes
-SUB_FILES+=		openssh
+USE_RC_SUBR=		openssh
 PLIST_SUB+=		NOTBASE="@comment "
 PLIST_SUB+=		BASE=""
 PLIST_SUB+=		BASEPREFIX="${PREFIX}"
(this is within a .if defined(WITH_OVERWRITE_BASE))

>How-To-Repeat:
Enable WITH_OVERWRITE_BASE and attempt to install the port.

>Fix:
Reverting the above part of the diff allows me to install
openssh-portable. Not sure about the original purpose of the change,
but it's at least a work-around.
>Release-Note:
>Audit-Trail:
>Unformatted: