ports/139657: net/asterisk-bristuff fails to install trying to execute bash script

[Pavel Gubin]

>Number:         139657
>Category:       ports
>Synopsis:       net/asterisk-bristuff fails to install trying to execute bash script
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Oct 15 22:40:01 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Pavel Gubin
>Release:        6.4
>Organization:
Lazy
>Environment:
FreeBSD srv.local 6.4-RELEASE-p6 FreeBSD 6.4-RELEASE-p6 #1: Mon Sep 28 02:15:02 TSD 2009     pg at srv.2lazy.ru:/usr/obj/usr/src/sys/Srv  i386
>Description:
net/asterisk-bristuff port fails to install properly without shells/bash installed, because Makefile trying to generate and install pkg-config spec file with bash script build_tools/mkpkgconfig (in asterisk's source directory).
>How-To-Repeat:
1) Ensure no bash can be found in your PATH
2) cd /usr/ports/net/asterisk-bristuff; make install
>Fix:
Seems that build_tools/mkpkgconfig script not only uses bashisms, but also implicitly uses perl, and Makefile tries to install pkgconfig spec file intto /usr/lib/pkgconfig instead of /usr/local/libdata/pkgconfig.

Seems that this spec file is not very useful anyway, so simplest way is to comment out its generation and installation.



Patch attached with submission follows:

--- nocodecnego-patch-Makefile.orig	2009-09-17 02:33:37.000000000 +0700
+++ nocodecnego-patch-Makefile	2009-10-16 04:35:24.000000000 +0700
@@ -39,7 +39,12 @@
    ASTCFLAGS+=$(shell if test $(BSDVERSION) -lt 500016 ; then echo "-D_THREAD_SAFE"; fi)
    AST_LIBS+=$(shell if test  $(BSDVERSION) -lt 502102 ; then echo "-lc_r"; else echo "-pthread"; fi)
  endif
-@@ -408,15 +410,15 @@
+@@ -404,19 +406,19 @@
+ 	rm -f build_tools/menuselect-deps
+ 
+ datafiles: _all
+-	if [ x`$(ID) -un` = xroot ]; then CFLAGS="$(ASTCFLAGS)" bash build_tools/mkpkgconfig $(DESTDIR)/usr/lib/pkgconfig; fi
++#	if [ x`$(ID) -un` = xroot ]; then CFLAGS="$(ASTCFLAGS)" bash build_tools/mkpkgconfig $(DESTDIR)/usr/lib/pkgconfig; fi
  # Should static HTTP be installed during make samples or even with its own target ala
  # webvoicemail?  There are portions here that *could* be customized but might also be
  # improved a lot.  I'll put it here for now.


>Release-Note:
>Audit-Trail:
>Unformatted: