ports/139607: [Patch] editors/openoffice.org-3-devel: Add knobs for experimental Graphite support

[Nikola Lecic]

>Number:         139607
>Category:       ports
>Synopsis:       [Patch] editors/openoffice.org-3-devel: Add knobs for experimental Graphite support
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Oct 14 16:50:04 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Nikola Lecic
>Release:        FreeBSD 8.0-RC1 i386
>Organization:
>Environment:

FreeBSD xxx 8.0-RC1 FreeBSD 8.0-RC1 #0: Thu Sep 17 20:45:19 UTC 2009     root at almeida.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386

>Description:

OpenOffice.org has an experimental support for Graphite smart font rendering
since 3.2 m56. It is enabled for Linux and Windows only.

However, Graphite-enabled OpenOffice.org compiles and works on FreeBSD too.
I haven't tested it thoroughly, but everything seems to work as expected,
including PDF export. Please see the following demo with three SIL's 
Graphite-enabled fonts:

Screenshot: http://anthesphoria.net/FreeBSD/tmp/Graphite-Demo-FreeBSD-OOo-DEV300_60-3.2.20090926.png
ODT file: http://anthesphoria.net/FreeBSD/tmp/Graphite-Demo-FreeBSD-OOo-DEV300_60-3.2.20090926.odt

The buildlog: http://anthesphoria.net/FreeBSD/tmp/sr-openoffice.org-3.2.20090926-with-graphite.log.bz2
(compiled with LOCALIZED_LANG=sr WITH_CUPS=yes WITH_TTF_BYTECODE_ENABLED=yes WITHOUT_MOZILLA=yes WITH_GRAPHITE=yes)

The patch provides an option to use system Graphite (graphics/silgraphite),
however, the wording should maybe include some warning since this will not
work without OOo libgraphite patches (for now). If this possibility is not
needed at this moment, I will modify the patch.

>How-To-Repeat:
	
>Fix:

--- openoffice.org-3-devel.patch begins here ---
Index: files/Makefile.knobs
===================================================================
RCS file: /home/ncvs/ports/editors/openoffice.org-3-devel/files/Makefile.knobs,v
retrieving revision 1.62
diff -u -r1.62 Makefile.knobs
--- files/Makefile.knobs	4 Sep 2009 23:58:20 -0000	1.62
+++ files/Makefile.knobs	14 Oct 2009 13:29:01 -0000
@@ -57,6 +57,19 @@
 CONFIGURE_ARGS+=	--with-system-icu=no
 .endif
 
+.if defined(WITH_GRAPHITE)
+CONFIGURE_ARGS+=	--enable-graphite=yes --without-stlport
+.else
+CONFIGURE_ARGS+=	--enable-graphite=no
+.endif
+
+.if defined(WITH_SYSTEM_GRAPHITE) && defined(WITH_GRAPHITE)
+LIB_DEPENDS+=		graphite.3:${PORTSDIR}/graphics/silgraphite
+CONFIGURE_ARGS+=	--with-system-graphite=yes
+.else
+CONFIGURE_ARGS+=	--with-system-graphite=no
+.endif
+
 pre-fetch:
 	@${ECHO} "OPTIONS:"
 .if !defined(WITH_DEBUG)
@@ -79,6 +92,23 @@
 	@${ECHO} "You can compile OOo with devel/icu from ports with"
 	@${ECHO} "make -DWITH_SYSTEM_ICU"
 .endif
+.if !defined(WITH_GRAPHITE)
+	@${ECHO}
+	@${ECHO} "You can compile OOo with Graphite smart font rendering with"
+	@${ECHO} "make -DWITH_GRAPHITE"
+.else
+	@${ECHO}
+	@${ECHO} "WARNING: Graphite support enabled, --without-stlport added"
+	@${ECHO} "to configure arguments."
+.endif
+.if !defined(WITH_SYSTEM_GRAPHITE)
+	@${ECHO}
+	@${ECHO} "You can compile OOo with graphics/silgraphite from ports with"
+	@${ECHO} "make -DWITH_SYSTEM_GRAPHITE"
+.elif !defined(WITH_GRAPHITE)
+	@${ECHO}
+	@${ECHO} "To use system Graphite, WITH_GRAPHITE must be set as well."
+.endif
 .if !defined(WITHOUT_CUPS)
 	@${ECHO}
 	@${ECHO} "You can compile OOo without CUPS support with"
Index: files/patch-configure
===================================================================
RCS file: files/patch-configure
diff -N files/patch-configure
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ files/patch-configure	14 Oct 2009 13:29:57 -0000
@@ -0,0 +1,11 @@
+--- configure	2009-10-13 21:32:34.000000000 +0200
++++ configure	2009-10-13 21:34:20.000000000 +0200
+@@ -19991,7 +19991,7 @@
+ 
+ { $as_echo "$as_me:$LINENO: checking whether to enable graphite support" >&5
+ $as_echo_n "checking whether to enable graphite support... " >&6; }
+-if test "$_os" = "WINNT" -o "$_os" = "Linux" && test "z$enable_graphite" == "z" -o "$enable_graphite" != "no" ; then
++if test "$_os" = "WINNT" -o "$_os" = "Linux" -o "$_os" = "FreeBSD" && test "z$enable_graphite" = "z" -o "$enable_graphite" != "no" ; then
+     { $as_echo "$as_me:$LINENO: result: yes" >&5
+ $as_echo "yes" >&6; }
+     ENABLE_GRAPHITE="TRUE"
--- openoffice.org-3-devel.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted: