ports/139374: [patch] graphics/xpdf fix build with lesstif

[dirk.meyer at dinoex.sub.org]

>Number:         139374
>Category:       ports
>Synopsis:       [patch] graphics/xpdf fix build with lesstif
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Oct 06 08:00:11 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Dirk Meyer
>Release:        FreeBSD 8.0-BETA4
>Organization:
privat
>Environment:

	FreeBSD 7.x FreeBSD 8.x
	/etc/make.conf
	WANT_LESSTIF=YES

>Description:

	xdpf does not build with lesstif.
	Error mesasge:
In file included from XPDFApp.cc:18:
XPDFViewer.h:338: error: 'nColorMenuItems' was not declared in this scope

	bails out at:
	[...]
#if USE_COMBO_BOX
  Widget zoomComboBox;
#else
  Widget zoomMenu;
  Widget zoomMenuBtns[nZoomMenuItems];
  Widget colorMenuBtns[nColorMenuItems];
#endif
	[...]

	nColorMenuItems is not defined at all,
	neither in lestif nor in open-motif itself.

	The following detection stuff is wrong.
	[...]
#if (XmVERSION >= 2 && !defined(LESSTIF_VERSION))
#  define USE_COMBO_BOX 1
#else
#  undef USE_COMBO_BOX
#endif
	[...]

	Problem reported at 08th Nov 2008
	To: araujo at freebsd.org 
	Feedback received at 10th Nov 2008
	Details reported at 11th Nov 2008

>How-To-Repeat:

	pkg_add lesstif-0.95.2_1,2.tbz
	cd /usr/ports/graphics/xpdf && make WANT_LESTIF=1

>Fix:

	
	a) fix the patch-zz-xpdf-annot.20080728a
	   by removing "!defined(LESSTIF_VERSION))" in XPDFViewer.h

	b) or Apply this patch.

Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/graphics/xpdf/Makefile,v
retrieving revision 1.91
diff -u -r1.91 Makefile
--- Makefile	18 Apr 2009 17:27:21 -0000	1.91
+++ Makefile	6 Oct 2009 07:34:30 -0000
@@ -78,6 +78,10 @@
 # add support for adding/deleting drawing annotations in PDF files
 PATCH_SITES+=   http://info.iet.unipi.it/~luigi/FreeBSD/
 PATCHFILES+=    patch-zz-xpdf-annot.20080728a
+
+post-patch:
+	${REINPLACE_CMD} -e 's|undef USE_COMBO_BOX|define USE_COMBO_BOX 1|' \
+		${WRKSRC}/xpdf/XPDFViewer.h
 .endif
 
 post-install:


>Release-Note:
>Audit-Trail:
>Unformatted: