ports/134552: [patch] SpamAssassin loses mail when killed by a signal

[Eric van Gyzen]

>Number:         134552
>Category:       ports
>Synopsis:       [patch] SpamAssassin loses mail when killed by a signal
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri May 15 02:20:02 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Eric van Gyzen
>Release:        FreeBSD 7.1-RELEASE i386
>Organization:
>Environment:
System: FreeBSD marvin.vangyzen.net 7.1-RELEASE FreeBSD 7.1-RELEASE #0: Thu Jan 1 14:37:25 UTC 2009 root at logan.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386

>Description:

When SpamAssassin 3.2.5 is killed by a signal, it exits with a zero
exit status.  When used with procmail, this causes mail to be lost,
because procmail thinks spamassassin completed successfully, but
spamassassin did not write the filtered mail to stdout to be
reclaimed by procmail for further processing and delivery.

For details, see:

    https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6033

SpamAssassin 3.2.5 was built with 7.1-RELEASE and 7.2-RELEASE,
so this will potentially affect a large number of FreeBSD users.

I am running /usr/local/bin/spamassassin from procmailrc;
perhaps the issue would not happen if spamd/spamc were used.

>How-To-Repeat:

N/A

>Fix:

Put this patch in ports/mail/p5-Mail-SpamAssassin/files.
It is r759764 from the SpamAssassin SVN repository,
linked from Comment #8 in the bug referenced above.
Apparently, it will be included in 3.2.6.

--- patch-spamassassin.raw begins here ---
--- spamassassin.raw.orig	2009-05-14 20:48:01.000000000 -0500
+++ spamassassin.raw	2009-05-14 20:48:19.000000000 -0500
@@ -530,7 +530,7 @@
     $mail->finish();      # bug 5626: remove temp files etc.
     $mail = undef;
   }
-  exit 0;
+  exit 15;
 }
 
 # ---------------------------------------------------------------------------
--- patch-spamassassin.raw ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted: