ports/136284: [patch] net-mgmt/p5-Cflow correct BUILD_DEPENDS

[Frank Wall]

>Number:         136284
>Category:       ports
>Synopsis:       [patch] net-mgmt/p5-Cflow correct BUILD_DEPENDS
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jul 03 15:10:01 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Frank Wall
>Release:        7.1-RELEASE-p6
>Organization:
>Environment:
FreeBSD XXX 7.1-RELEASE-p6 FreeBSD 7.1-RELEASE-p6 #0: Tue Jun  9 16:26:47 UTC 2009     root at i386-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC  i386

>Description:
The port net-mgmt/p5-Cflow has the option WITH_FLOW_TOOLS.
This option depends on net-mgmt/flow-tools. When you try to build
net-mgmt/p5-Cflow with this option it will fail, if net-mgmt/flow-tools
was not installed before.

>How-To-Repeat:
1. make sure net-mgmt/flow-tools is NOT installed

2. try to build net-mgmt/p5-Cflow:
   WITH_FLOW_TOOLS=1 make -C /usr/ports/net-mgmt/p5-Cflow

3. it fails complaining that ftlib.h from net-mgmt/flow-tools is missing:

===>  Building for p5-Cflow-1.053
cp Cflow.pm blib/lib/Cflow.pm
AutoSplitting blib/lib/Cflow.pm (blib/lib/auto/Cflow)
/usr/local/bin/perl5.8.9 /usr/local/lib/perl5/5.8.9/ExtUtils/xsubpp  -typemap /usr/local/lib/perl5/5.8.9/ExtUtils/typemap  Cflow.xs > Cflow.xsc && mv Cflow.xsc Cflow.c
cc -c  -I/usr/local/include  -O2 -fno-strict-aliasing -pipe -I/usr/local/include -DOSU -O2 -fno-strict-aliasing -pipe    -DVERSION=\"1.053\"  -DXS_VERSION=\"1.053\" -DPIC -fPIC "-I/usr/local/lib/perl5/5.8.9/mach/CORE"   Cflow.c
Cflow.xs:62:21: error: ftlib.h: No such file or directory
Cflow.xs: In function 'XS_Cflow_find':
Cflow.xs:575: error: storage size of 'fs' isn't known
Cflow.xs:580: error: storage size of 'ftv' isn't known
Cflow.xs:669: error: 'FT_IO_FLAG_READ' undeclared (first use in this function)
Cflow.xs:669: error: (Each undeclared identifier is reported only once
Cflow.xs:669: error: for each function it appears in.)
Cflow.xs:761: error: storage size of 'first' isn't known
Cflow.xs:761: error: storage size of 'last' isn't known
Cflow.xs:763: warning: assignment makes pointer from integer without a cast
Cflow.xs:767: error: dereferencing pointer to incomplete type

>Fix:
Add net-mgmt/flow-tools to BUILD_DEPENS:
BUILD_DEPENDS+=	${LOCALBASE}/lib/libft.a:${PORTSDIR}/net-mgmt/flow-tools

Patch attached with submission follows:

--- Makefile.orig	2009-07-03 16:45:36.000000000 +0200
+++ Makefile	2009-07-03 15:33:55.000000000 +0200
@@ -17,6 +17,7 @@
 
 .if defined(WITH_FLOW_TOOLS)
 RUN_DEPENDS+=	${LOCALBASE}/lib/libft.a:${PORTSDIR}/net-mgmt/flow-tools
+BUILD_DEPENDS+=	${LOCALBASE}/lib/libft.a:${PORTSDIR}/net-mgmt/flow-tools
 
 CFLAGS+=	-I${LOCALBASE}/include -DOSU
 CONFIGURE_ARGS+=	\


>Release-Note:
>Audit-Trail:
>Unformatted: