ports/130903: misc/kdeedu4 does not build libsbigudrv.so during upgrade

[Jan Henrik Sylvester]

>Number:         130903
>Category:       ports
>Synopsis:       misc/kdeedu4 does not build libsbigudrv.so during upgrade
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jan 23 00:20:01 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Jan Henrik Sylvester
>Release:        7.1-RELEASE-p2 i386
>Organization:
>Environment:
>Description:
If libsbigudrv.so is already installed, for example from a previous version of the same port during a portupgrade, misc/kdeedu4 links against the old version of libsbigudrv.so and consequently does not build a new one. As a result, the old version is removed with the old package and the library is missing for the new install.

This has happened to me during an upgrade from kdeedu-4.1.1_1 to kdeedu-4.1.4, but it probably applies for other upgrades, too, since the configure reported the same for the upgrade to kdeedu-4.1.4_1.

With a previous version installed:
  -- Found SBIG: /usr/local/kde4/lib/libsbigudrv.so
  ...
  + libsbigudrv
  ...
  Congratulations! All external packages have been found.
Without a previous version installed:
  -- Could not find OPTIONAL package SBIG
  ..
  -- The following OPTIONAL packages could NOT be located on your system.
  -- Consider installing them to enable more features from this software.
  + libsbigudrv, 1.00: SBIG Universal Driver <http://indi.sourceforge.net/>
  Needed by KStars.
>How-To-Repeat:
- Have kdeedu-4.1.1_1 installed and portupgrade to kdeedu-4.1.4.
- Try to 'pkg_create -b kdeedu-4.1.4' and observe that lib/libsbigudrv.so* is missing.
>Fix:
mkdir misc/kdeedu4/files
patch < kdeedu4-always-libsbigudrv.txt

This will remove all non-comment lines from cmake/modules/FindSBIG.cmake. The configure process will not find libsbigudrv.so from the previous version anymore and it is build and installed.

Patch attached with submission follows:

--- misc/kdeedu4/files/patch-rm-cmake-modules-FindSBIG.cmake	1970-01-01 01:00:00.000000000 +0100
+++ misc/kdeedu4/files/patch-rm-cmake-modules-FindSBIG.cmake	2009-01-22 23:02:23.000000000 +0100
@@ -0,0 +1,27 @@
+diff -u ../cmake/modules/FindSBIG.cmake~ ../cmake/modules/FindSBIG.cmake
+--- ../cmake/modules/FindSBIG.cmake~	2008-01-05 00:56:03.000000000 +0100
++++ ../cmake/modules/FindSBIG.cmake	2009-01-22 22:56:28.000000000 +0100
+@@ -10,23 +10,3 @@
+ # Redistribution and use is allowed according to the terms of the BSD license.
+ # For details see the accompanying COPYING-CMAKE-SCRIPTS file.
+ 
+-if (SBIG_LIBRARIES)
+-
+-  # in cache already
+-  set(SBIG_FOUND TRUE)
+- message(STATUS "Found SBIG: ${SBIG_LIBRARIES}")
+-
+-else (SBIG_LIBRARIES)
+-
+-  find_library(SBIG_LIBRARIES NAMES sbigudrv
+-    PATHS
+-    ${_obLinkDir}
+-    ${GNUWIN32_DIR}/lib
+-  )
+-
+-  include(FindPackageHandleStandardArgs)
+-  FIND_PACKAGE_HANDLE_STANDARD_ARGS(SBIG DEFAULT_MSG SBIG_LIBRARIES )
+-   
+-  mark_as_advanced(SBIG_LIBRARIES)
+-
+-endif (SBIG_LIBRARIES)


>Release-Note:
>Audit-Trail:
>Unformatted: