ports/131495: [PATCH] audio/ogg2mp3: take maintainership, fix endian related problem

[Tobias Rehbein]

>Number:         131495
>Category:       ports
>Synopsis:       [PATCH] audio/ogg2mp3: take maintainership, fix endian related problem
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Feb 08 13:20:03 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Tobias Rehbein
>Release:        FreeBSD 7.1-RELEASE-p1 i386
>Organization:
>Environment:
System: FreeBSD sushi.pseudo.local 7.1-RELEASE-p1 FreeBSD 7.1-RELEASE-p1 #33: Tue Jan 13 21:39:05 CET 2009 tobi at sushi.pseudo.local:/usr/obj/usr/src/sys/SUSHI i386


	
>Description:
	Converted mp3-files sound like pure static. This is fixed by removing the "-x" flag from the lame commandline. I guess this is related to newer audio/lame versions.	

	The last time I submitted a PR regarding this port I missed to take over maintainership.
	
>How-To-Repeat:
	
>Fix:

	

--- ogg2mp3-0.5_3.diff begins here ---
diff -ruN audio/ogg2mp3.orig/Makefile audio/ogg2mp3/Makefile
--- audio/ogg2mp3.orig/Makefile	2009-02-08 12:01:04.000000000 +0100
+++ audio/ogg2mp3/Makefile	2009-02-08 13:25:01.000000000 +0100
@@ -6,11 +6,11 @@
 
 PORTNAME=	ogg2mp3
 PORTVERSION=	0.5
-PORTREVISION=	2
+PORTREVISION=	3
 CATEGORIES=	audio
 MASTER_SITES=	http://amor.cms.hu-berlin.de/~h0444y2j/pub/
 
-MAINTAINER=	ports at FreeBSD.org
+MAINTAINER=	tobias.rehbein at web.de
 COMMENT=	Perl script that converts Ogg Vorbis files to MP3 format
 
 RUN_DEPENDS=	lame:${PORTSDIR}/audio/lame \
diff -ruN audio/ogg2mp3.orig/files/patch-ogg2mp3 audio/ogg2mp3/files/patch-ogg2mp3
--- audio/ogg2mp3.orig/files/patch-ogg2mp3	2009-02-05 11:47:09.000000000 +0100
+++ audio/ogg2mp3/files/patch-ogg2mp3	2009-02-08 13:29:35.000000000 +0100
@@ -1,5 +1,26 @@
---- ./ogg2mp3.orig	2009-02-02 20:13:18.000000000 +0000
-+++ ./ogg2mp3	2009-02-02 20:13:44.000000000 +0000
+--- ./ogg2mp3.orig	2005-05-16 18:07:33.000000000 +0000
++++ ./ogg2mp3	2009-02-08 12:29:27.000000000 +0000
+@@ -1,4 +1,4 @@
+-#!/usr/bin/perl
++#!/usr/local/bin/perl
+ 
+ # ogg2mp3
+ #
+@@ -51,10 +51,10 @@
+ print "  Thanks to all who took an interest. Have fun!\n";
+ print " ------------------------------------------------------------------- \n\n";
+ 
+-my $MP3ENC  = "/usr/bin/lame";
+-#my $MP3INFO = "/usr/bin/mp3_check";
+-my $OGGINFO = "/usr/bin/ogginfo";
+-my $OGG123  = "/usr/bin/ogg123";
++my $MP3ENC  = "/usr/local/bin/lame";
++#my $MP3INFO = "/usr/local/bin/mp3_check";
++my $OGGINFO = "/usr/local/bin/ogginfo";
++my $OGG123  = "/usr/local/bin/ogg123";
+ 
+ # check presence of executables
+ stat($MP3ENC) or die "Error: $MP3ENC not present!\n";
 @@ -68,7 +68,7 @@
  
  # build genre hash
@@ -9,3 +30,15 @@
  while(<GENRES>) {
      chomp;
      next if /^\s*$/;
+@@ -308,10 +308,8 @@
+ 	
+ 	$mp3outputfile_escaped = shell_quote($mp3outputfile);
+ 	$oggfile_escaped = shell_quote($oggfile);
+-	# this took me some time to figure
+-	# note that byte order is swapped by lame via -x option
+ 	# TODO: somebody please tell me how to supress the "Assuming bla bla" output without devnull
+-	$result = system("$OGG123 $decquiet -d raw -f - $oggfile_escaped | $MP3ENC $encquiet -r -x -q $quality -b $bitrate -s $frequency -m $channels $infostring - $mp3outputfile_escaped");
++	$result = system("$OGG123 $decquiet -d raw -f - $oggfile_escaped | $MP3ENC $encquiet -r -q $quality -b $bitrate -s $frequency -m $channels $infostring - $mp3outputfile_escaped");
+ 
+ 	# TODO: find some widely used mp3 checker
+ 	# disabled the checking due to lack of checker
--- ogg2mp3-0.5_3.diff ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted: