ports/141733: [patch] audio/akode-plugins-xiph: Makefile fixes for portlint

Glen Barber glen.j.barber at gmail.com
Fri Dec 18 02:50:04 UTC 2009


>Number:         141733
>Category:       ports
>Synopsis:       [patch] audio/akode-plugins-xiph: Makefile fixes for portlint
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Fri Dec 18 02:50:03 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Glen Barber
>Release:        8.0-STABLE
>Organization:
>Environment:
FreeBSD orion 8.0-STABLE FreeBSD 8.0-STABLE #9 r200334: Wed Dec  9 19:02:03 EST 2009     root at orion:/usr/obj/usr/src/sys/ORION  amd64
>Description:
portlint finds FATAL errors in the Makefile for this port, such as:
 - use a tab (not space) after a variable name
 - extra item placed in the PORTNAME section
 - extra item placed in the MAINTAINER section

Additionally, portlint warns PLIST_FLAGS should be used when pkg-plist contains 6 or less entries.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -ruN /usr/ports/audio/akode-plugins-xiph/Makefile /usr/local/ports/audio/akode-plugins-xiph/Makefile
--- /usr/ports/audio/akode-plugins-xiph/Makefile	2009-08-02 15:32:11.000000000 -0400
+++ /usr/local/ports/audio/akode-plugins-xiph/Makefile	2009-12-17 21:13:28.000000000 -0500
@@ -5,15 +5,15 @@
 # $FreeBSD: ports/audio/akode-plugins-xiph/Makefile,v 1.25 2009/08/02 19:32:11 mezz Exp $
 #
 
-PORTNAME=   akode-plugins-${PORTNAMESUFX}
-PORTVERSION=    2.0.2
+PORTNAME=	akode-plugins-${PORTNAMESUFX}
+PORTVERSION=	2.0.2
 PORTREVISION=	2
-PORTEPOCH=  1
-CATEGORIES= audio kde
-MASTER_SITES=   ${MASTER_SITE_GENTOO}
-MASTER_SITE_SUBDIR=distfiles
-DISTNAME=   30375-akode-${PORTVERSION}.tar.bz2
-EXTRACT_SUFX=   # none
+PORTEPOCH=	1
+CATEGORIES=	audio kde
+MASTER_SITES=	${MASTER_SITE_GENTOO}
+MASTER_SITE_SUBDIR=	distfiles
+DISTNAME=	30375-akode-${PORTVERSION}.tar.bz2
+EXTRACT_SUFX=
 
 MAINTAINER=	kde at FreeBSD.org
 COMMENT=	FLAC/Speex/Vorbis decoder plugin for akode
@@ -29,12 +29,16 @@
 PORTNAMESUFX=	${PLUGIN:S/_sink//:S/_decoder//:S/src_//}
 
 USE_AUTOTOOLS=	libltdl
-USE_AUTOTOOLS=  libtool:22
+USE_AUTOTOOLS=	libtool:22
 USE_BZIP2=	yes
 USE_GMAKE=	yes
 WRKSRC=		${WRKDIR}/akode-${PORTVERSION}
 USE_LDCONFIG=	yes
 
+PLIST_FILES=	lib/libakode_xiph_decoder.a \
+		lib/libakode_xiph_decoder.la \
+		lib/libakode_xiph_decoder.so
+
 CONFIGURE_ENV+=	LDFLAGS=-L${WRKSRC}/akode/lib/.libs
 CONFIGURE_ARGS+=--with-extra-libs=${LOCALBASE}/lib \
 		--with-extra-includes=${LOCALBASE}/include
diff -ruN /usr/ports/audio/akode-plugins-xiph/pkg-plist /usr/local/ports/audio/akode-plugins-xiph/pkg-plist
--- /usr/ports/audio/akode-plugins-xiph/pkg-plist	2006-03-30 15:30:02.000000000 -0500
+++ /usr/local/ports/audio/akode-plugins-xiph/pkg-plist	1969-12-31 19:00:00.000000000 -0500
@@ -1,3 +0,0 @@
-lib/libakode_xiph_decoder.a
-lib/libakode_xiph_decoder.la
-lib/libakode_xiph_decoder.so


>Release-Note:
>Audit-Trail:
>Unformatted:



More information about the freebsd-ports-bugs mailing list