ports/137712: ImageMagick does not build with FreeBSD 7.2

[Stephen Montgomery-Smith]

>Number:         137712
>Category:       ports
>Synopsis:       ImageMagick does not build with FreeBSD 7.2
>Confidential:   no
>Severity:       critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Thu Aug 13 04:00:16 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Stephen Montgomery-Smith
>Release:        FreeBSD 7.2-STABLE i386
>Organization:
>Environment:
System: FreeBSD cauchy 7.2-STABLE FreeBSD 7.2-STABLE #0: Wed Jul 29 15:00:29 CDT 2009 stephen at cauchy:/usr/obj/usr/src/sys/GENERIC i386


	
>Description:

The port ImageMagick-6.5.4.10 does not build on FreeBSD 7.2, because it uses the function carg, which is only available on FreeBSD 8.

If you look at /usr/src/lib/msun/src/s_carg.c you will see that carg(z) is a drop in replacement for atan2(cimag(z), creal(z)).  Thus the proposed fix may as well be implemented on FreeBSD 8 as well as FreeBSD 7.2.

>How-To-Repeat:
	
>Fix:

Put a patch into files which effects the following patch:

--- magick/fourier-orig.c	2009-08-12 21:39:18.000000000 -0500
+++ magick/fourier.c	2009-08-12 21:40:13.000000000 -0500
@@ -515,7 +515,7 @@
       for (x=0L; x < (long) fourier_info->center; x++)
       {
         magnitude[i]=cabs(fourier[i]);
-        phase[i]=carg(fourier[i]);
+        phase[i]=atan2(cimag(fourier[i]),creal(fourier[i]));
         i++;
       }
   else


>Release-Note:
>Audit-Trail:
>Unformatted: