ports/137364: devel/gnome-vfs: add missing files to pkg-plist and make HAL support optional

Sun Aug 2 21:20:02 UTC 2009

>Number:         137364
>Category:       ports
>Synopsis:       devel/gnome-vfs: add missing files to pkg-plist and make HAL support optional
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Aug 02 21:20:01 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Carlos A. M. dos Santos
>Release:        8.0-BETA2
>Organization:
N.A.
>Environment:
FreeBSD avatar 8.0-BETA2 FreeBSD 8.0-BETA2 #2: Tue Jul 28 23:21:41 BRT 2009     root at avatar:/usr/obj/usr/src/sys/Compaq_nx6320  amd64

>Description:
After uninstalling gnome-vfs, a lot of files named %gconf-tree*.xml are left at /usr/local/etc/gconf/gconf.xml.defaults/ because they are not listed in the pkg-plist file.

Just like other packages, usage of HAL is optional on gnome-vfs. Some users do not want to depend on HAL, so I propose making it optional.
>How-To-Repeat:
List the contents of /usr/local/etc/gconf/gconf.xml.defaults/ (if it exists). Build and install the devel/gnome-vfs port, as of version 2.24.1.0. Uninstall it and list the contents of /usr/local/etc/gconf/gconf.xml.defaults/ again.
>Fix:
Apply the attached patch. It adds the missing file names to pkg-plist, makes the dependence on HAL optional and bumps the port revision number.

Patch attached with submission follows:

diff -dur gnome-vfs.orig/Makefile gnome-vfs/Makefile

--- gnome-vfs.orig/Makefile	2009-03-18 21:35:02.000000000 -0300
+++ gnome-vfs/Makefile	2009-08-02 14:48:03.000000000 -0300
@@ -8,7 +8,7 @@
 
 PORTNAME=	gnome-vfs
 PORTVERSION=	2.24.1
-PORTREVISION?=	0
+PORTREVISION=	1
 CATEGORIES=	devel gnome
 MASTER_SITES=	GNOME
 DIST_SUBDIR=	gnome2
@@ -20,7 +20,6 @@
 
 .if !defined(REFERENCE_PORT)
 
-LIB_DEPENDS=	hal.1:${PORTSDIR}/sysutils/hal
 RUN_DEPENDS=	${LOCALBASE}/share/mime/magic:${PORTSDIR}/misc/shared-mime-info
 
 USE_GMAKE=	yes
@@ -47,10 +46,18 @@
 		system_http_proxy.schemas system_smb.schemas
 
 OPTIONS=	SAMBA "Enable SMB volume support" on \
-		MDNS "Enable Bonjour/Rendezvous support" on
+		MDNS "Enable Bonjour/Rendezvous support" on \
+		HAL "Enable HAL support" on
 
 .include <bsd.port.pre.mk>
 
+.if !defined(WITHOUT_HAL)
+CONFIGURE_ARGS+=--enable-hal
+LIB_DEPENDS+=	hal.1:${PORTSDIR}/sysutils/hal
+.else
+CONFIGURE_ARGS+=--disable-hal
+.endif
+
 .if exists(${LOCALBASE}/lib/libfam.so) || !defined(WITHOUT_FAM)
 USE_FAM=	yes
 .endif
diff -dur gnome-vfs.orig/pkg-plist gnome-vfs/pkg-plist
--- gnome-vfs.orig/pkg-plist	2009-03-18 21:35:02.000000000 -0300
+++ gnome-vfs/pkg-plist	2009-08-02 17:43:42.000000000 -0300
@@ -7,6 +7,82 @@
 bin/gnomevfs-monitor
 bin/gnomevfs-mv
 bin/gnomevfs-rm
+etc/gconf/gconf.xml.defaults/%gconf-tree-af.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-ar.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-as.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-ast.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-az.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-be.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-bg.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-bn.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-bn_IN.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-bs.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-ca.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-cs.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-cy.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-da.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-de.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-dz.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-el.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-en_CA.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-en_GB.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-es.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-et.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-eu.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-fi.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-fr.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-gl.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-gu.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-he.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-hi.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-hr.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-hu.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-id.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-it.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-ja.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-ka.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-kn.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-ko.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-lt.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-lv.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-mai.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-mg.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-mk.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-ml.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-mn.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-mr.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-ms.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-nb.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-ne.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-nl.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-nn.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-nso.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-or.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-pa.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-pl.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-pt.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-pt_BR.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-ro.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-ru.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-sk.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-sl.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-sq.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-sr.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-sr at ije.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-sr at latin.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-sv.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-ta.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-te.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-th.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-tr.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-uk.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-vi.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-xh.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-zh_CN.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-zh_HK.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-zh_TW.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree-zu.xml
+etc/gconf/gconf.xml.defaults/%gconf-tree.xml
 etc/gnome-vfs-2.0/modules/default-modules.conf
 %%SAMBA%%etc/gnome-vfs-2.0/modules/smb-module.conf
 etc/gnome-vfs-2.0/modules/ssl-modules.conf


>Release-Note:
>Audit-Trail:
>Unformatted:

