ports/133718: amarok-kde4 2.0.2 has last.fm support broken

[Eugene M. Zheganin]

>Number:         133718
>Category:       ports
>Synopsis:       amarok-kde4 2.0.2 has last.fm support broken
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Apr 14 03:30:01 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Eugene M. Zheganin
>Release:        7.1-RELEASE-p3
>Organization:
Norma JSC.
>Environment:
FreeBSD bsdrookie.norma.com. 7.1-RELEASE-p3 FreeBSD 7.1-RELEASE-p3 #0: Thu Mar  5 10:11:05 YEKT 2009     emz at ns.hq.norma.perm.ru:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
amarok-kde4 2.0.2_1 has last.fm support broken, no listened tracks submission is possible.

Full thread here: https://bugs.kde.org/show_bug.cgi?id=188678
Patch for 2.0.2 here: https://bugs.kde.org/attachment.cgi?id=32615

Patch is tested, solves this problem for Linux users; I tested it on FreeBSD, it does fix last.fm submission.


Patch can be applied as it's published with no further editing, as its paths fit to the FreeBSD ports system.
>How-To-Repeat:
Install amarok-kde4 2.0.2_1 from fresh ports and register to last.fm service. Try to submit some tracks.
>Fix:
https://bugs.kde.org/attachment.cgi?id=32615

Patch attached with submission follows:

--- src/services/lastfm/LastFmServiceSettings.cpp
+++ src/services/lastfm/LastFmServiceSettings.cpp
@@ -94,14 +94,12 @@
     debug() << "username:" << QString( QUrl::toPercentEncoding( Ws::Username ) );
 
     QString authToken =  md5( ( m_configDialog->kcfg_ScrobblerUsername->text() + md5( m_configDialog->kcfg_ScrobblerPassword->text().toUtf8() ) ).toUtf8() );
-    QString sign_key = md5( ( "api_key" + QString( Ws::ApiKey ) + "authToken" + authToken + "methodauth.getMobileSession" + QString( Ws::SharedSecret ) ).toUtf8() );
     
     // now authenticate w/ last.fm and get our session key
     WsReply* reply = WsRequestBuilder( "auth.getMobileSession" )
     .add( "username", m_configDialog->kcfg_ScrobblerUsername->text() )
     .add( "authToken", authToken )
     .add( "api_key", Ws::ApiKey )
-    .add( "api_sig", sign_key )
     .get();
     
     connect( reply, SIGNAL( finished( WsReply* ) ), SLOT( onAuthenticated( WsReply* ) ) );
--- src/services/lastfm/LastFmService.cpp
+++ src/services/lastfm/LastFmService.cpp
@@ -115,14 +115,12 @@
     debug() << "username:" << QString( QUrl::toPercentEncoding( Ws::Username ) );
 
     QString authToken =  md5( ( m_userName + md5( password.toUtf8() ) ).toUtf8() );
-    QString sign_key = md5( ( "api_key" + QString( Ws::ApiKey ) + "authToken" + authToken + "methodauth.getMobileSession" + QString( Ws::SharedSecret ) ).toUtf8() );
     
     // now authenticate w/ last.fm and get our session key
     WsReply* reply = WsRequestBuilder( "auth.getMobileSession" )
     .add( "username", m_userName )
     .add( "authToken", authToken )
     .add( "api_key", Ws::ApiKey )
-    .add( "api_sig", sign_key )
     .get();
     
     connect( reply, SIGNAL( finished( WsReply* ) ), SLOT( onAuthenticated( WsReply* ) ) );


>Release-Note:
>Audit-Trail:
>Unformatted: