ports/127464: www/apache13* knobs not honoring "YES"

[Aleksandr Stankevic]

>Number:         127464
>Category:       ports
>Synopsis:       www/apache13* knobs not honoring "YES"
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Sep 18 09:30:02 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Aleksandr Stankevic
>Release:        
>Organization:
>Environment:
>Description:
www/apache13* doesn't honor "YES" for WITH_* stuff:

> grep -R "== yes" /usr/ports/www/apache13/
/usr/ports/www/apache13/Makefile:.if defined(WITHOUT_APACHE_EXPAT) && ${WITHOUT_APACHE_EXPAT} == yes
/usr/ports/www/apache13/Makefile:.if defined(WITH_APACHE_SUEXEC) && ${WITH_APACHE_SUEXEC} == yes
/usr/ports/www/apache13/Makefile:.if defined(WITH_APACHE_PERF_TUNING) && ${WITH_APACHE_PERF_TUNING} == yes

So, setting i.e. WITH_APACHE_SUEXEC="YES" won't work, it has to be WITH_APACHE_SUEXEC=yes

There are also same problems for other www/apache13-* ports (apache13-modssl and friends)
>How-To-Repeat:
cd /usr/ports/www/apache13/
make WITH_APACHE_SUEXEC=YES
find ./ -name suexec #doesn't find anything

make clean
make WITH_APACHE_SUEXEC=yes
find ./ -name suexec # find a compiled suexec binary
>Fix:
make it honor the 'yes' flag case-insensitively or don't look at the YES at all, and only look if it's defined?


>Release-Note:
>Audit-Trail:
>Unformatted: