ports/127847: Too low fixed image limit in libgphoto2-2.4.2

[Henrik Herranen]

>Number:         127847
>Category:       ports
>Synopsis:       Too low fixed image limit in libgphoto2-2.4.2
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Oct 04 07:20:09 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Henrik Herranen
>Release:        7.1-PRERELEASE #14
>Organization:
>Environment:
FreeBSD koti 7.1-PRERELEASE FreeBSD 7.1-PRERELEASE #14: Tue Sep 30 17:37:23 EEST 2008     leopold at koti:/usr/obj/usr/src/sys/JEEVES  i386

>Description:
gphoto2 cannot handle situations where there are more than 1024 images on a memory card, which in itself is a situation is very typical already on 16 GB Compact Flash cards, not to even speak of new 100 GB cards. The problem is caused port libgphoto2-2.4.2 file gphoto2-list.c line 75 that says:
#define MAX_ENTRIES 1024

>How-To-Repeat:
Take a memory card with over 1024 images, and try to copy images above the 1024th image, and you'll get the following message:
*** Error (-8: 'Fixed limit exceeded') ***       

>Fix:
The quick fix is to change this to a larger number, i.e. 8192 or 16384. I've been using a version modified as this and it works well for my needs.
#define MAX_ENTRIES 8192

However, who such an arbitrary restriction? The correct way would be to dynamically allocate as much space as is needed.


>Release-Note:
>Audit-Trail:
>Unformatted: