ports/128820: ports/graphics/libgphoto2 does not compile

[Helge Oldach]

>Number:         128820
>Category:       ports
>Synopsis:       ports/graphics/libgphoto2 does not compile
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Nov 12 17:20:03 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Helge Oldach
>Release:        FreeBSD 6.4-1373 i386
>Organization:
>Environment:

System: FreeBSD localhost 6.4-1373 FreeBSD 6.4-1373 #0: Fri Nov 7 21:10:20 CET 2008 toor at localhost:/usr/obj/usr/src/sys/HMO i386

>Description:

Fails to compile WITHOUT_NLS since the update to 2.4.3 two days ago:

# make -DWITHOUT_NLS -C /usr/ports/graphics/libgphoto2
===================lots of output cut away====================
depbase=`echo smal/ultrapocket.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
        /bin/sh /usr/obj/usr/ports/graphics/libgphoto2/work/gnome-libtool --tag=CC   --mode=compile cc -DHAVE_CONFIG_H -I. -I..  -I.. -I.. -I../libgphoto2_port -I../libgphoto2 -I../libgphoto2  -Wall -g -D_GPHOTO2_INTERNAL_CODE -DLOCALEDIR=\"/usr/local/share/locale\" -DCAMLIBS=\"/usr/local/lib/libgphoto2/2.4.3\" -I.. -I.. -I../libgphoto2_port -I../libgphoto2 -I../libgphoto2  -Wall -g -D_GPHOTO2_INTERNAL_CODE -I/usr/local/include -O2 -fno-strict-aliasing -pipe -Wall -Wmissing-declarations -Wmissing-prototypes -O2 -fno-strict-aliasing -pipe -Wall -Wmissing-declarations -Wmissing-prototypes -MT smal/ultrapocket.lo -MD -MP -MF $depbase.Tpo -c -o smal/ultrapocket.lo smal/ultrapocket.c &&\
        mv -f $depbase.Tpo $depbase.Plo
 cc -DHAVE_CONFIG_H -I. -I.. -I.. -I.. -I../libgphoto2_port -I../libgphoto2 -I../libgphoto2 -Wall -g -D_GPHOTO2_INTERNAL_CODE -DLOCALEDIR=\"/usr/local/share/locale\" -DCAMLIBS=\"/usr/local/lib/libgphoto2/2.4.3\" -I.. -I.. -I../libgphoto2_port -I../libgphoto2 -I../libgphoto2 -Wall -g -D_GPHOTO2_INTERNAL_CODE -I/usr/local/include -O2 -fno-strict-aliasing -pipe -Wall -Wmissing-declarations -Wmissing-prototypes -O2 -fno-strict-aliasing -pipe -Wall -Wmissing-declarations -Wmissing-prototypes -MT smal/ultrapocket.lo -MD -MP -MF smal/.deps/ultrapocket.Tpo -c smal/ultrapocket.c  -fPIC -DPIC -o smal/.libs/ultrapocket.o
smal/ultrapocket.c: In function `ultrapocket_getrawpicture':
smal/ultrapocket.c:236: warning: implicit declaration of function `setlocale'
smal/ultrapocket.c:236: error: `LC_ALL' undeclared (first use in this function)
smal/ultrapocket.c:236: error: (Each undeclared identifier is reported only once
smal/ultrapocket.c:236: error: for each function it appears in.)
smal/ultrapocket.c:236: warning: assignment makes pointer from integer without a cast
smal/ultrapocket.c: In function `ultrapocket_getpicture':
smal/ultrapocket.c:316: error: `LC_ALL' undeclared (first use in this function)
smal/ultrapocket.c:316: warning: assignment makes pointer from integer without a cast
gmake[3]: *** [smal/ultrapocket.lo] Error 1
gmake[3]: Leaving directory `/usr/obj/usr/ports/graphics/libgphoto2/work/libgphoto2-2.4.3/camlibs'
gmake[2]: *** [all-recursive] Error 1
gmake[2]: Leaving directory `/usr/obj/usr/ports/graphics/libgphoto2/work/libgphoto2-2.4.3/camlibs'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/usr/obj/usr/ports/graphics/libgphoto2/work/libgphoto2-2.4.3'
gmake: *** [all] Error 2
*** Error code 2

Stop in /usr/ports/graphics/libgphoto2.

>How-To-Repeat:

>Fix:

--- camlibs/smal/ultrapocket.c.ORIG	2008-10-18 19:55:46.000000000 +0200
+++ camlibs/smal/ultrapocket.c	2008-11-11 18:29:12.000000000 +0100
@@ -22,6 +22,8 @@
 #include <stdlib.h>
 #include <string.h>
 
+#include <locale.h>
+
 #include <gphoto2/gphoto2-port-log.h>
 #include <gphoto2/gphoto2-library.h>
 #include <gphoto2/gphoto2-result.h>
>Release-Note:
>Audit-Trail:
>Unformatted: