ports/128747: multimedia/vlc-devel fix conflicting WITH_SKINS + WITHOUT_QT4

Joseph S. Atkinson jsa at wickedmachine.net
Mon Nov 10 09:40:02 UTC 2008


>Number:         128747
>Category:       ports
>Synopsis:       multimedia/vlc-devel fix conflicting WITH_SKINS + WITHOUT_QT4
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Mon Nov 10 09:40:00 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Joseph S. Atkinson
>Release:        
>Organization:
>Environment:
>Description:
If a user opts not to build the QT interface, but has opted for the skinnable UI, configure fails.

This informs people selecting these via the OPTIONS framework that QT4 is required for SKINS. If a user defines both anyway via `make config` or in the environment, then WITH_SKINS will be silently ignored in favor of honoring WITHOUT_QT4.

No need to bump PORTREVISION.

Discovered reviewing config.log sent via private email.

Thanks A. B.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- Makefile.orig	2008-11-10 03:32:26.000000000 -0500
+++ Makefile	2008-11-10 04:04:26.000000000 -0500
@@ -51,7 +51,7 @@
 OPTIONS+=	SVG "SVG graphics support" Off
 OPTIONS+=	SVGALIB "SVGALIB video output" Off
 OPTIONS+=	SHOUT "Shout2 support" Off
-OPTIONS+=	SKINS "Enable winamp skins interface" Off
+OPTIONS+=	SKINS "Enable winamp skins interface (requires QT4)" Off
 OPTIONS+=	SPEEX "Speex voice codec support" On
 OPTIONS+=	THEORA "OGG/Vorbis video codec support" On
 OPTIONS+=	TWOLAME "Twolame mpeg2 audio encoder support" On
@@ -165,7 +165,7 @@
 CONFIGURE_ARGS+=--disable-notify
 .endif
 
-.if defined(WITH_SKINS) && !defined(WITHOUT_SKINS)
+.if defined(WITH_SKINS) && !defined(WITHOUT_SKINS) && !defined(WITHOUT_QT4)
 CONFIGURE_ARGS+=--enable-skins2
 .else
 CONFIGURE_ARGS+=--disable-skins2


>Release-Note:
>Audit-Trail:
>Unformatted:



More information about the freebsd-ports-bugs mailing list