ports/123325: Samba3 port does not build

[greg byshenk]

>Number:         123325
>Category:       ports
>Synopsis:       Samba3 port does not build
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri May 02 08:40:00 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     greg byshenk
>Release:        FreeBSD 6.3-STABLE i386
>Organization:
none
>Environment:
System: FreeBSD ats-core-2.aoes.com 6.3-STABLE FreeBSD 6.3-STABLE #75: Thu May 1 12:50:18 CEST 2008
root at ats-core-2.aoes.com:/usr/obj/usr/src/sys/AOES6 i386

x86 32-bit, both intel and amd
FreeBSD 6-STABLE on or after 24 April 2008

>Description:
	On 6-STABLE as of 24 April 2008 (and later), samba3 build fails.

Basically my problem is that the current Samba3 (samba-3.0.28,1) won't build
on a recent 6-STABLE system (I noticed it with sources csup'd 24 April, and
it continues with sources csup'd today, 1 May). The strange thing is that
this is a version of samba that has previously built successfully, on the
machine and with the configuration that is now failing.  (I was attempting
to rebuild because I saw some strange library errors.)  This at least
suggests to me that the problem is _not_ due to something changing with Samba,
but to some other change that is being reflected in the Samba build.


The system in question is built from sources csup'd today (1 May 2008), with
all installed ports current as of today.  The same Samba did build successfully
with a source and ports tree csup'd on 7 March 2008.

As a test to see if there is some problem with the ports dependencies, I've
tried a 'portupgrade -fR samba'; all of the dependencies built fine, but then
I got the same error when attempting to build Samba itself. It is not
definitive, but this suggests to me that this is not a ports problem (per se),
but a kernel/world problem.

This latter is highlighted by the fact that Samba builds without error on a
system with sources csup'd on 17 April.  That is, if I take the exact same
system on which the build fails, revert my world/kernel to a build from
17 April (leaving everything else exactly the same), then the error
disappears and Samba builds successfully.

>How-To-Repeat:
	update a system to 6-STABLE and attempt to build samba3 port.

Compiling smbd/oplock_linux.c
smbd/oplock_linux.c: In function `signal_handler':
smbd/oplock_linux.c:73: error: structure has no member named `si_fd'
The following command failed:
cc -I. -I/usr/ports/net/samba3/work/samba-3.0.28/source  -O2 -fno-strict-aliasing -pipe
+-D_SAMBA_BUILD_=3 -I/usr/local/include
+-I/usr/ports/net/samba3/work/samba-3.0.28/source/iniparser/src -Iinclude -I./include  -I. -I.
+-I./lib/replace -I./lib/talloc -I./tdb/include -I./libaddns -I./librpc -DHAVE_CONFIG_H
+-I/usr/local/include -DLDAP_DEPRECATED    -I/usr/ports/net/samba3/work/samba-3.0.28/source/lib
+-D_SAMBA_BUILD_=3 -fPIC -DPIC -c smbd/oplock_linux.c -o smbd/oplock_linux.o
*** Error code 1

Stop in /usr/ports/net/samba3/work/samba-3.0.28/source.
*** Error code 1

Stop in /usr/ports/net/samba3.
*** Error code 1

Stop in /usr/ports/net/samba3.

>Fix:

	Downgrade system to 6-STABLE as of 17 April 2008.  The build succeeds.


>Release-Note:
>Audit-Trail:
>Unformatted: