ports/122055: graphics/ImageMagick PerlMagick tests fail due to t/setattribute.t typo

[Eric Sobocinski]

>Number:         122055
>Category:       ports
>Synopsis:       graphics/ImageMagick PerlMagick tests fail due to t/setattribute.t typo
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Mar 24 20:00:09 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Eric Sobocinski
>Release:        6.3-STABLE
>Organization:
>Environment:
FreeBSD chewtoy.fuzzbutt.net 6.3-RELEASE-p1 FreeBSD 6.3-RELEASE-p1 #2: Thu Mar 20 14:17:35 EDT 2008     root at chewtoy.fuzzbutt.net:/usr/obj/usr/src/sys/FUZZBUTT6  i386
>Description:
I'm building ImageMagick 6.3.6.9 as updated by cvsup on 24 March 2008 with most options enabled, including Bundled Self-Tests and Perl Support.  When a "make test" or an inclusive make is run, the ImageMagick base package tests complete successfully, and the individual PerlMagick tests appear to run successfully, but the PerlMagick tests summary exits with an error:



..<an expected pile of output>...
====================
All 696 tests passed
====================
cd PerlMagick && make CC='cc' test
/bin/sh ../magick.sh PERL_DL_NONLAZY=1 /usr/local/bin/perl5.8.8 "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/bzlib/*.t t/fpx/*.t t/jbig/*.t t/jpeg/*.t t/jp2/*.t t/png/*.t t/tiff/*.t t/zlib/*.t
t/blob..............ok
t/bzlib/read........ok
t/bzlib/write.......ok
t/composite.........ok
t/filter............ok
t/fpx/read..........ok
t/fpx/write.........ok
t/getattribute......ok
t/jbig/read.........ok
t/jbig/write........ok
t/jp2/read..........ok
t/jpeg/read.........ok
t/jpeg/write........ok
t/montage...........ok
t/png/read-16.......ok
t/png/read..........ok
t/png/write-16......ok
t/png/write.........ok
t/read..............ok
t/setattribute...... All 71 subtests passed
t/tiff/read.........ok
t/tiff/write........ok
t/write.............ok
t/zlib/read.........ok
t/zlib/write........ok

Test Summary Report
-------------------
t/setattribute.t (Wstat: 0 Tests: 71 Failed: 0)
  Parse errors: No plan found in TAP output
Files=25, Tests=341, 14 wallclock secs ( 0.38 usr  0.14 sys + 11.46 cusr  1.70 csys = 13.68 CPU)
Result: FAIL
Failed 1/25 test programs. 0/341 subtests failed.
*** Error code 255

Stop in /usr/ports/graphics/ImageMagick/work/ImageMagick-6.3.6/PerlMagick.
*** Error code 1

Stop in /usr/ports/graphics/ImageMagick/work/ImageMagick-6.3.6.
*** Error code 1

Stop in /usr/ports/graphics/ImageMagick/work/ImageMagick-6.3.6.
*** Error code 1

Stop in /usr/ports/graphics/ImageMagick.
#



Looking narrowly at setattribute.t confirms that it is the problem:

# make TEST_FILES=t/setattribute.t test
/bin/sh ../magick.sh PERL_DL_NONLAZY=1 /usr/local/bin/perl5.8.8 "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/setattribute.t
t/setattribute...... All 71 subtests passed

Test Summary Report
-------------------
t/setattribute.t (Wstat: 0 Tests: 71 Failed: 0)
  Parse errors: No plan found in TAP output
Files=1, Tests=71,  1 wallclock secs ( 0.03 usr  0.02 sys +  0.53 cusr  0.23 csys =  0.81 CPU)
Result: FAIL
Failed 1/1 test programs. 0/71 subtests failed.
*** Error code 255

Stop in /usr/ports/graphics/ImageMagick/work/ImageMagick-6.3.6/PerlMagick.
#  
>How-To-Repeat:
Building ImageMagick from Ports with options IMAGEMAGICK_TESTS and IMAGEMAGICK_PERL (WITH_PERL).

I suppose there could be other dependencies, but I haven't checked exhaustively since I know an easy fix.
>Fix:
--- t/setattribute.t    2007-11-04 17:43:42.000000000 -0500
+++ /tmp/setattribute_fixed.t   2008-03-24 15:02:16.000000000 -0400
@@ -7 +7 @@
-BEGIN { $| = 1; $test=1, print "1..71)\n"; }
+BEGIN { $| = 1; $test=1, print "1..71\n"; }

>Release-Note:
>Audit-Trail:
>Unformatted: