ports/121453: [patch] improve Mk/bsd.sites.mk MASTER_SITE_GOOGLE_CODE variable

[Edwin Groothuis]

The following reply was made to PR ports/121453; it has been noted by GNATS.

From: Edwin Groothuis <edwin at mavetju.org>
To: Dmitry Marakasov <amdmi3 at amdmi3.ru>
Cc: FreeBSD Gnats Submit <freebsd-gnats-submit at freebsd.org>
Subject: Re: ports/121453: [patch] improve Mk/bsd.sites.mk MASTER_SITE_GOOGLE_CODE variable
Date: Fri, 7 Mar 2008 12:56:31 +1100

 On Fri, Mar 07, 2008 at 12:50:04AM +0000, Dmitry Marakasov wrote:
 > The following reply was made to PR ports/121453; it has been noted by GNATS.
 > 
 > From: Dmitry Marakasov <amdmi3 at amdmi3.ru>
 > To: bug-followup at FreeBSD.org
 > Cc:  
 > Subject: Re: ports/121453: [patch] improve Mk/bsd.sites.mk
 > 	MASTER_SITE_GOOGLE_CODE variable
 > Date: Fri, 7 Mar 2008 03:49:10 +0300
 > 
 >  * Edwin Groothuis (edwin at mavetju.org) wrote:
 >  
 >  >  > I submitted this as a PR instead of just commited it because it
 >  >  > might cause some controvacy.
 >  >  I will commit this patch in the next week if I don't receibe any
 >  >  negative replies on it.
 >  Can't MASTER_SITE_SUBDIR be used for that cases? I think using
 >  MASTER_SITE_SUBDIR for not-actually-a-subdir is a less pain than
 >  introducing a new variable.
 
 I have looked at it, but I couldn't really find a way to get it
 added as the default.
 
 The current code is:
 
     MASTER_SITES_GOOGLE_CODE=	http://${PORTNAME}.googlecode.com/files
 
 This one works for 75% of the ports.
 
 If we would use the following code:
 
     MASTER_SITES_GOOGLE_CODE=	http://%%SUBDIR%%.googlecode.com/files
 
 we would need to set MASTER_SITE_SUBDIR for all of them. But strictly
 speaking, it isn't a real sub-directory to start with.
 
 Using the variable GOOGLENAME, or GOOGLEHOST (which actually makes
 more sense than GOOGLENAME), it would be a good compromis.
 
 Edwin
 -- 
 Edwin Groothuis      |            Personal website: http://www.mavetju.org
 edwin at mavetju.org    |              Weblog: http://www.mavetju.org/weblog/