ports/119908: [maintainer] multimedia/handbrake

[Jona Joachim]

>Number:         119908
>Category:       ports
>Synopsis:       [maintainer] multimedia/handbrake
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jan 23 02:50:01 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Jona Joachim
>Release:        FreeBSD 7.0-BETA4 i386
>Organization:
none
>Environment:
System: FreeBSD nirvana.my.domain 7.0-BETA4 FreeBSD 7.0-BETA4 #0: Thu Dec 6 11:05:32 CET 2007 root at nirvana.my.domain:/usr/obj/usr/src/sys/HYPOCENTER i386
>Description:
Hi!
Sorry for sending this in so late, I plain forgot about it :/
Our handbrake port doesn't currently build on amd64 because it is built
without -fPIC.
The following patch enables -fPIC on all archs except for i386.
ffmpeg (which is included in handbrake) doesn't build with -fPIC on i386,
this is a known issue. However it should build on amd64.
Unfortunately I can't test it myself, I only have FreeBSD boxes with i386.
So it would be kind if somebody could test-build handbrake on amd64 with
the following patch applied.

Best regards,
Jona
>How-To-Repeat:
>Fix:
--- handbrake.diff begins here ---
diff -ur /usr/ports/multimedia/handbrake/Makefile ./Makefile
--- /usr/ports/multimedia/handbrake/Makefile	2008-01-18 08:32:28.000000000 +0100
+++ ./Makefile	2008-01-23 03:04:48.000000000 +0100
@@ -71,8 +71,10 @@
 # nasm/yasm needed by x264
 .if ${ARCH}=="i386"
 BUILD_DEPENDS+=	nasm:${PORTSDIR}/devel/nasm
+PICFLAGS=
 .else
 BUILD_DEPENDS+=	yasm>=0.6.0:${PORTSDIR}/devel/yasm
+PICFLAGS=	-fPIC -DPIC
 .endif
 
 CONFIGURE_ENV+=	PKG_CONFIG_PATH=${WRKSRC}/contrib/lib/pkgconfig
@@ -102,8 +104,8 @@
 	@${REINPLACE_CMD} -e 's|%%CC%%|${CC}|g ; \
 		s|%%PTHREAD_LIBS%%|${PTHREAD_LIBS}|g ; \
 		s|%%CONTRIB%%|${WRKSRC}/contrib|g ; \
-		s|./bootstrap|${SETENV} CC="${CC}" CXX="${CXX}" CFLAGS="${CFLAGS}" CXXFLAGS="${CXXFLAGS}" ${CONFIGURE_ENV} ./bootstrap|g ; \
-		s|./configure|${SETENV} CC="${CC}" CXX="${CXX}" CFLAGS="${CFLAGS}" CXXFLAGS="${CXXFLAGS}" ${CONFIGURE_ENV} ./configure|g' \
+		s|./bootstrap|${SETENV} CC="${CC}" CXX="${CXX}" CFLAGS="${CFLAGS} ${PICFLAGS}" CXXFLAGS="${CXXFLAGS}" ${CONFIGURE_ENV} ./bootstrap|g ; \
+		s|./configure|${SETENV} CC="${CC}" CXX="${CXX}" CFLAGS="${CFLAGS} ${PICFLAGS}" CXXFLAGS="${CXXFLAGS}" ${CONFIGURE_ENV} ./configure|g' \
 			${WRKSRC}/contrib/Jamfile
 	@${REINPLACE_CMD} -e 's|-O3||g ; s|-O20||g ; s|-O4 -ffast-math||g ; \
 		s| -mtune=.*"|"|g ; s| -mcpu=.*"|"|g ; \
Only in .: Makefile~
--- handbrake.diff ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted: