ports/119272: security/dirmngr was not linking in 6.1-RELEASE

[Ricardo Nabinger Sanchez]

>Number:         119272
>Category:       ports
>Synopsis:       security/dirmngr was not linking in 6.1-RELEASE
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jan 02 17:30:00 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Ricardo Nabinger Sanchez
>Release:        6.1-RELEASE
>Organization:
-
>Environment:
FreeBSD sauron.lan.box 6.1-RELEASE FreeBSD 6.1-RELEASE #0: Sun May  7 04:32:43 UTC 2006     root at opus.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
With an up-to-date ports tree (as of today, 02-jan-2008), security/dirmngr was failing at linking stage.  With the proposed patch, which adds libiconv as a dependency, dirmngr was successfully upgraded.

Error message:

cc -I../jnlib -I/usr/local/include  -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/pth -O2 -fno-strict-aliasing -pipe -O2 -g -pipe -march=athlon-xp -Wall  -L/usr/local/lib -L/usr/local/lib -o dirmngr dirmngr.o server.o crlcache.o crlfetch.o certcache.o cdblib.o ldap.o http.o misc.o ocsp.o estream.o estream-printf.o validate.o exechelp.o get-path.o ../jnlib/libjnlib.a  -L/usr/local/lib -lassuan-pth -L/usr/local/lib -lgcrypt -L/usr/local/lib -lgpg-error -L/usr/local/lib -lksba -lgpg-error -L/usr/local/lib/pth -lpth  
./jnlib/libjnlib.a(utf8conv.o)(.text+0x32a): In function `set_native_charset':
/tmp/home/cvsup/ports/security/dirmngr/work/dirmngr-1.0.1/jnlib/utf8conv.c:287: undefined reference to `libiconv_open'
./jnlib/libjnlib.a(utf8conv.o)(.text+0x337):/tmp/home/cvsup/ports/security/dirmngr/work/dirmngr-1.0.1/jnlib/utf8conv.c:293: undefined reference to `libiconv_close'
./jnlib/libjnlib.a(utf8conv.o)(.text+0x347):/tmp/home/cvsup/ports/security/dirmngr/work/dirmngr-1.0.1/jnlib/utf8conv.c:294: undefined reference to `libiconv_open'
./jnlib/libjnlib.a(utf8conv.o)(.text+0x354):/tmp/home/cvsup/ports/security/dirmngr/work/dirmngr-1.0.1/jnlib/utf8conv.c:300: undefined reference to `libiconv_close'
./jnlib/libjnlib.a(utf8conv.o)(.text+0x491): In function `native_to_utf8':
/tmp/home/cvsup/ports/security/dirmngr/work/dirmngr-1.0.1/jnlib/utf8conv.c:369: undefined reference to `libiconv_open'
./jnlib/libjnlib.a(utf8conv.o)(.text+0x505):/tmp/home/cvsup/ports/security/dirmngr/work/dirmngr-1.0.1/jnlib/utf8conv.c:388: undefined reference to `libiconv'
./jnlib/libjnlib.a(utf8conv.o)(.text+0x519):/tmp/home/cvsup/ports/security/dirmngr/work/dirmngr-1.0.1/jnlib/utf8conv.c:407: undefined reference to `libiconv_close'
./jnlib/libjnlib.a(utf8conv.o)(.text+0xa07): In function `do_utf8_to_native':
/tmp/home/cvsup/ports/security/dirmngr/work/dirmngr-1.0.1/jnlib/utf8conv.c:637: undefined reference to `libiconv_open'
./jnlib/libjnlib.a(utf8conv.o)(.text+0xa6b):/tmp/home/cvsup/ports/security/dirmngr/work/dirmngr-1.0.1/jnlib/utf8conv.c:654: undefined reference to `libiconv'
./jnlib/libjnlib.a(utf8conv.o)(.text+0xab7):/tmp/home/cvsup/ports/security/dirmngr/work/dirmngr-1.0.1/jnlib/utf8conv.c:677: undefined reference to `libiconv_close'
./jnlib/libjnlib.a(utf8conv.o)(.text+0xb95): In function `jnlib_iconv_open':
/tmp/home/cvsup/ports/security/dirmngr/work/dirmngr-1.0.1/jnlib/utf8conv.c:712: undefined reference to `libiconv_open'
./jnlib/libjnlib.a(utf8conv.o)(.text+0xba5): In function `jnlib_iconv':
/tmp/home/cvsup/ports/security/dirmngr/work/dirmngr-1.0.1/jnlib/utf8conv.c:729: undefined reference to `libiconv'
./jnlib/libjnlib.a(utf8conv.o)(.text+0xbb5): In function `jnlib_iconv_close':
/tmp/home/cvsup/ports/security/dirmngr/work/dirmngr-1.0.1/jnlib/utf8conv.c:742: undefined reference to `libiconv_close'
gmake[2]: *** [dirmngr] Error 1
gmake[2]: Leaving directory `/tmp/home/cvsup/ports/security/dirmngr/work/dirmngr-1.0.1/src'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/tmp/home/cvsup/ports/security/dirmngr/work/dirmngr-1.0.1'
gmake: *** [all] Error 2
*** Error code 2

Stop in /home/cvsup/ports/security/dirmngr.
** Command failed [exit code 1]: /usr/bin/script -qa /tmp/portupgrade.34655.0 env UPGRADE_TOOL=portupgrade UPGRADE_PORT=dirmngr-0.9.7_2 UPGRADE_PORT_VER=0.9.7_2 make
** Fix the problem and try again.
--->  Build of security/dirmngr ended at: Wed, 02 Jan 2008 14:59:47 -0200 (consumed 00:00:30)
--->  Upgrade of security/dirmngr ended at: Wed, 02 Jan 2008 14:59:47 -0200 (consumed 00:00:30)
--->  ** Upgrade tasks 1: 0 done, 0 ignored, 0 skipped and 1 failed
--->  Listing the results (+:done / -:ignored / *:skipped / !:failed)
        ! security/dirmngr (dirmngr-0.9.7_2)    (linker error)
--->  Packages processed: 0 done, 0 ignored, 0 skipped and 1 failed
--->  Session ended at: Wed, 02 Jan 2008 14:59:47 -0200 (consumed 00:00:33)
Exit 1
>How-To-Repeat:

>Fix:
--- Makefile.orig       Wed Jan  2 15:10:16 2008
+++ Makefile    Wed Jan  2 15:12:24 2008
@@ -18,7 +18,8 @@
 LIB_DEPENDS=   gcrypt.13:${PORTSDIR}/security/libgcrypt \
                gpg-error.0:${PORTSDIR}/security/libgpg-error \
                ksba.17:${PORTSDIR}/security/libksba \
-               pth:${PORTSDIR}/devel/pth
+               pth:${PORTSDIR}/devel/pth \
+               iconv:${PORTSDIR}/converters/libiconv
 
 USE_BZIP2=     yes
 USE_OPENLDAP=  yes
@@ -28,7 +29,7 @@
 INFO=          dirmngr
 MAN1=          dirmngr-client.1 dirmngr.1
 
-CONFIGURE_ENV+=        LDFLAGS="${LDFLAGS} -L${LOCALBASE}/lib"
+CONFIGURE_ENV+=        LDFLAGS="${LDFLAGS} -L${LOCALBASE}/lib -liconv"
 
 .if defined(WITHOUT_NLS)
 CONFIGURE_ARGS+=--disable-nls

>Release-Note:
>Audit-Trail:
>Unformatted: