ports/120889: index fails to build: malformed conditonal in bsd.gnome.mk

[Pavel Gubin]

>Number:         120889
>Category:       ports
>Synopsis:       index fails to build: malformed conditonal in bsd.gnome.mk
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Feb 20 17:50:00 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Pavel Gubin
>Release:        6.3-RELEASE
>Organization:
TUSUR
>Environment:
FreeBSD lynx.ie.tusur.ru 6.3-RELEASE FreeBSD 6.3-RELEASE #2: Fri Jan 18 23:38:13 TSK 2008     pg at lynx.ie.tusur.ru:/var/data/obj/var/data/6s/src/sys/Lynx  i386

>Description:
The problem is like mentioned in ports/111509

Updating the ports index ... Generating INDEX.tmp - please
wait.."/usr/ports/Mk/bsd.gnome.mk", line 643: Malformed conditional (${_USE_GNOME_ALL:Mgtk12}=="")
"/usr/ports/Mk/bsd.port.mk", line 6147: if-less endif
make: fatal errors encountered -- cannot continue

>How-To-Repeat:
0. csup to the latest tree
1. run portsdb -Uu or make index from /usr/ports/

>Fix:
I've just enclosed into "" the expression in question, then index generated normally.

diff -u bsd.gnome.mk.orig bsd.gnome.mk
--- bsd.gnome.mk.orig   2008-02-20 22:49:12.000000000 +0600
+++ bsd.gnome.mk        2008-02-20 22:49:12.000000000 +0600
@@ -640,7 +640,7 @@
 IGNORE+=the GNOME ${GNOME_DESKTOP_VERSION} desktop
 .         endif
 .      endif
-.  if ${_USE_GNOME_ALL:M${component}}==""
+.  if "${_USE_GNOME_ALL:M${component}}"==""
 IGNORE=        cannot install: Unknown component ${component}
 .  endif
 _USE_GNOME+=   ${${component}_USE_GNOME_IMPL} ${component}


>Release-Note:
>Audit-Trail:
>Unformatted: