ports/120510: handbrake doesn't build on amd64

[Wes Morgan]

>Number:         120510
>Category:       ports
>Synopsis:       handbrake doesn't build on amd64
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Feb 10 21:10:03 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Wes Morgan
>Release:        7.0
>Organization:
>Environment:
FreeBSD volatile 7.0-PRERELEASE FreeBSD 7.0-PRERELEASE #4: Sun Jan 13 11:48:41 CST 2008     morganw at volatile:/usr/src/sys/amd64/compile/VOLATILE  amd64
>Description:
Port marked as broken on AMD64. Build fails with "R_X86_64_32S" errors.
>How-To-Repeat:
Remove broken flag and build port on amd64.
>Fix:
Compile a52 and mpeg2dec without the -prefer-non-pic flag for libtool.


Patch attached with submission follows:

--- ../../work/HandBrake/contrib/configure	2002-07-27 22:50:42.000000000 -0500
+++ contrib/a52dec/configure	2008-02-10 13:27:23.298399910 -0600
@@ -9640,7 +9640,7 @@
 
 
 
-LIBA52_CFLAGS="$LIBA52_CFLAGS -prefer-non-pic"
+LIBA52_CFLAGS="$LIBA52_CFLAGS"
 
 # Check whether --enable-double or --disable-double was given.
 if test "${enable_double+set}" = set; then
--- ../../work/HandBrake/contrib/liba52/configure.incl	2002-01-27 22:36:48.000000000 -0600
+++ contrib/a52dec/liba52/configure.incl	2008-02-10 13:27:37.130839289 -0600
@@ -2,7 +2,7 @@
 AC_SUBST([LIBA52_LIBS])
 
 dnl avoid -fPIC when possible
-LIBA52_CFLAGS="$LIBA52_CFLAGS -prefer-non-pic"
+LIBA52_CFLAGS="$LIBA52_CFLAGS"
 
 AC_ARG_ENABLE([double],
     [  --enable-double         use double-precision samples])
--- ../../work/HandBrake/contrib/mpeg2dec/configure~	2008-02-10 14:25:13.883591050 -0600
+++ contrib/mpeg2dec/configure	2008-02-10 14:25:13.888591248 -0600
@@ -23964,28 +23964,6 @@
 done
 
 
-
-
-echo "$as_me:$LINENO: checking if libtool supports -prefer-non-pic flag" >&5
-echo $ECHO_N "checking if libtool supports -prefer-non-pic flag... $ECHO_C" >&6
-    mkdir ac_test_libtool; cd ac_test_libtool; ac_cv_libtool_non_pic=no
-    echo "int g (int i); static int h (int i) {return g (i);} int f (int i) {return h (i);}" >f.c
-    echo "int (* hook) (int) = 0; int g (int i) {if (hook) i = hook (i); return i + 1;}" >g.c
-    ../libtool --mode=compile $CC $CFLAGS -prefer-non-pic \
-		-c f.c >/dev/null 2>&1 && \
-	../libtool --mode=compile $CC $CFLAGS -prefer-non-pic \
-		-c g.c >/dev/null 2>&1 && \
-	../libtool --mode=link $CC $CFLAGS -prefer-non-pic -o libfoo.la \
-		-rpath / f.lo g.lo >/dev/null 2>&1 &&
-	ac_cv_libtool_non_pic=yes
-    cd ..; rm -fr ac_test_libtool; echo "$as_me:$LINENO: result: $ac_cv_libtool_non_pic" >&5
-echo "${ECHO_T}$ac_cv_libtool_non_pic" >&6
-    if test x"$ac_cv_libtool_non_pic" = x"yes"; then
-	LIBMPEG2_CFLAGS="$LIBMPEG2_CFLAGS -prefer-non-pic"
-    else
-	:
-    fi
-
 # Check whether --enable-accel-detect or --disable-accel-detect was given.
 if test "${enable_accel_detect+set}" = set; then
   enableval="$enable_accel_detect"


>Release-Note:
>Audit-Trail:
>Unformatted: