ports/126728: Unnessary dependancy: net/openslp for multimedia/vlc

[Joseph S. Atkinson]

>Number:         126728
>Category:       ports
>Synopsis:       Unnessary dependancy: net/openslp for multimedia/vlc
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Aug 22 05:00:12 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Joseph S. Atkinson
>Release:        8.0-CURRENT
>Organization:
>Environment:
>Description:
Remove dependency (and usage of) net/openslp from multimedia/vlc. Support for OpenSLP was added to VLC in 2003. Was set for FreeBSD's build via KNOB (defaulted on) by ahze@ almost 4 years ago. When VLC moved to OPTIONS, it was left out of the list, but still defaulted on do to the ".if !defined(WITHOUT_SLP)" stanza being left in.

VLC expunged support for OpenSLP in 2005.

Also, offer to take maintainership at least until VLC moves to Qt. funman at videolan.org has indicated via irc that he no longer uses FreeBSD or works with VLC and was actively seeking a new maintainer.
>How-To-Repeat:
cd /usr/ports/multimedia/vlc && make install
>Fix:
Remove the lingering references to OpenSLP.

Patch attached with submission follows:

Credit "Joseph S. Atkinson <jsa at wickedmachine.net>" if commited please

--- Makefile.orig	2008-08-22 00:20:41.000000000 -0400
+++ Makefile	2008-08-22 00:38:14.000000000 -0400
@@ -10,6 +10,7 @@
 
 PORTNAME=	vlc
 DISTVERSION=	0.8.6i
+PORTREVISION=	1
 PORTEPOCH=	2
 CATEGORIES=	multimedia audio ipv6 net www
 MASTER_SITES=	http://download.videolan.org/pub/videolan/vlc/${DISTVERSION}/ \
@@ -454,12 +455,6 @@
 CONFIGURE_ARGS+=--disable-gnutls
 .endif
 
-.if !defined(WITHOUT_SLP)
-LIB_DEPENDS+=	slp.1:${PORTSDIR}/net/openslp
-.else
-CONFIGURE_ARGS+=--disable-slp
-.endif
-
 .if !defined(WITHOUT_SPEEX)
 LIB_DEPENDS+=	speex.1:${PORTSDIR}/audio/speex
 CONFIGURE_ARGS+=--enable-speex
--- Makefile.inc.orig	2008-08-22 00:21:43.000000000 -0400
+++ Makefile.inc	2008-08-22 00:22:06.000000000 -0400
@@ -187,10 +187,6 @@
 # WITH_SSL=yes
 #  Enable TLS/SSL Support for web (httpd) interface
 #
-# WITHOUT_SLP=yes
-#  Disable SLP service discovery support
-#  * recommended if you want to stream media
-#
 # WITH_OPTIMIZED_CFLAGS=yes
 #  Compile with -O2 -ffast-math -fomit-frame-pointer
 #


>Release-Note:
>Audit-Trail:
>Unformatted: