ports/122735: [patch] Port mail/postfixadmin - incorrect syntax in mysqli_real_escape_string function

[Skalozubov Ilia]

>Number:         122735
>Category:       ports
>Synopsis:       [patch] Port mail/postfixadmin - incorrect syntax in mysqli_real_escape_string function
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Sun Apr 13 20:40:00 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Skalozubov Ilia
>Release:        
>Organization:
>Environment:
>Description:
Incorrect syntax of function mysqli_real_escape_string in functions.inc.php
This error occurs when option 'magic_quotes_gpc' disabled in php config and postfixadmin used own functions to quoting strings.
>How-To-Repeat:
Install postfixadmin with mysqli support.
Disable 'magic_quotes_gpc' in php config.
Open http://URL_TO_POSTFIXADMIN/admin/create-domain.php
When press button to create new domain, you'll get error messages.
>Fix:


Patch attached with submission follows:

--- functions.inc.php	2008-04-13 22:09:18.000000000 +0300
+++ functions.inc.php	2008-04-13 22:09:32.000000000 +0300
@@ -129,7 +129,12 @@
    if (get_magic_quotes_gpc () == 0)
    {
       if ($CONF['database_type'] == "mysql")  $escaped_string = mysql_real_escape_string ($string);
-      if ($CONF['database_type'] == "mysqli")  $escaped_string = mysqli_real_escape_string ($string);
+      if ($CONF['database_type'] == "mysqli")
+      {
+         $link = db_connect ();
+         $escaped_string = mysqli_real_escape_string ($link, $string);
+         mysqli_close ($link);
+      }
       if ($CONF['database_type'] == "pgsql")  $escaped_string = pg_escape_string ($string);
    }
    else


>Release-Note:
>Audit-Trail:
>Unformatted: