ports/122466: [patch] databases/tora port does not build when knob WITHOUT_KDE is set

[José García Juanino]

>Number:         122466
>Category:       ports
>Synopsis:       [patch] databases/tora port does not build when knob WITHOUT_KDE is set
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Apr 05 13:00:11 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     José García Juanino
>Release:        7.0-RELEASE
>Organization:
>Environment:
FreeBSD ********* 7.0-RELEASE FreeBSD 7.0-RELEASE #0: Thu Feb 28 13:54:34 CET 2008     root at sanabria.inad.es:/export/FreeBSD/obj70/export/FreeBSD/src70/sys/MK2008Feb28  i386
>Description:
When knob WITHOUT_KDE is set, tora does not build. At the final stage, it crashes with the following output:

/usr/local/oracle8-client/lib/libclntsh.a(sepco.o)(.text+0x7d): In function `sepcoget_login':
: undefined reference to `cuserid'

>How-To-Repeat:
Build the port with WITHOUT_KDE knob set
>Fix:
libcompat.a is not linking with the tora executable when WITHOUT_KDE is set because LIBCOMPAT variable is empty (check work/tora-1-3-end-of-life/Makefile). And this variable has not the correct value (-lcompat) because m4 macros (work/tora-1-3-end-of-life/config/m4/qtkde.m4)

   AC_CHECK_LIB(compat, main, [LIBCOMPAT="-lcompat"]) dnl for *BSD
   AC_SUBST(LIBCOMPAT)

are not taked into account when WITHOUT_KDE is set.

Therefore, adding that macros to configure.ac fixes the problem. I attach a new files/patch-configure.ac.

Regards

Patch attached with submission follows:

--- configure.ac.orig	2008-03-09 21:03:43.000000000 +0100
+++ configure.ac	2008-04-05 14:34:02.000000000 +0200
@@ -53,6 +53,9 @@
 AX_PATH_LIB_PCRE
 AM_PATH_CPPUNIT([1.10.2], found_cppunit=yes)
 AM_CONDITIONAL([CPPUNIT], [test "x$found_cppunit" = "xyes"])
+# is mandatory check for libcompat
+AC_CHECK_LIB(compat, main, [LIBCOMPAT="-lcompat"]) dnl for *BSD
+AC_SUBST(LIBCOMPAT)
 
 # Makefile.am uses these
 AM_CONDITIONAL(ENABLE_MONO, test "$enable_mono" = yes)


>Release-Note:
>Audit-Trail:
>Unformatted: