ports/116550: devel/tcltls 1.5.0 port enhancements

[Martin Matuska]

>Number:         116550
>Category:       ports
>Synopsis:       devel/tcltls 1.5.0 port enhancements
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Sep 22 14:20:01 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Martin Matuska
>Release:        FreeBSD 6.2-STABLE i386
>Organization:
>Environment:
System: FreeBSD 6.2-STABLE i386 and amd64
>Description:
The following changes are proposed:
- USE_TCL=83+
	tcltls works well with tcl 83 and higher
- OPTIONS: TCLLIB_TESTS
	because of firewalls, the tests may not run properly,
	user may choose to run the test suite
- request for maintainership
	to me: mm at FreeBSD.org
- PORTREVISION bump is NOT required

>How-To-Repeat:
>Fix:
Index: ports/devel/tcltls/Makefile
===================================================================
RCS file: /home/pcvs/ports/devel/tcltls/Makefile,v
retrieving revision 1.13
diff -u -r1.13 Makefile
--- ports/devel/tcltls/Makefile	11 Jun 2007 19:56:59 -0000	1.13
+++ ports/devel/tcltls/Makefile	22 Sep 2007 14:11:35 -0000
@@ -12,17 +12,19 @@
 MASTER_SITE_SUBDIR=tls
 DISTNAME=	tls${PORTVERSION}-src
 
-MAINTAINER=	mi at aldan.algebra.com
+MAINTAINER=	mm at FreeBSD.org
 COMMENT=	SSL extensions for TCL; dynamicly loadable
 
-LIB_DEPENDS+=	tcl${TCLVND}:${PORTSDIR}/lang/tcl${TCLVND}
-
-MANUAL_PACKAGE_BUILD=Self-tests fail/hang
+USE_TCL=	83+
 
 USE_OPENSSL=	Yes
 
 WRKSRC=	${WRKDIR}/tls${PORTVERSION:R}
 
+OPTIONS=	TCLTLS_TESTS	"Run tcltls tests before install"	off
+
+.include <bsd.port.pre.mk>
+
 PLIST_SUB+=	TCL_VER=${TCL_VER} DISTNAME="${DISTNAME}"
 MAKEFILE=	${FILESDIR}/Makefile.bsd
 MAKE_ENV=	TCL_VER=${TCL_VER} MKDIR="${MKDIR}" \
@@ -42,20 +44,19 @@
 	# The tests in ciphers.test are meaningless so far:
 	${MV} ${WRKSRC}/tests/ciphers.test ${WRKSRC}/tests/ciphers.test.broken
 
+.if defined(WITH_TCLTLS_TESTS)
+post-build test:
+	cd ${WRKSRC}/tests && env TCL_LIBRARY="${WRKSRC}" \
+		tclsh${TCL_VER} all.tcl
+.endif
+
 .if !defined(NOPORTDOCS)
 post-install:
 	${MKDIR} ${PREFIX}/share/doc/tls
 	${INSTALL_DATA} ${WRKSRC}/tls.htm ${PREFIX}/share/doc/tls/
 .endif
 
-post-build test:
-	cd ${WRKSRC}/tests && env TCL_LIBRARY="${WRKSRC}" \
-		tclsh${TCL_VER} all.tcl
-
-TCL_VER?=	8.4
-TCLVND=		${TCL_VER:S/.//}
-
-.include <bsd.port.mk>
-
 PLIST_SUBP!=	${SETENV} ${MAKE_ENV} ${MAKE} -f ${MAKEFILE} environ
 PLIST_SUB+=	${PLIST_SUBP}
+
+.include <bsd.port.post.mk>
>Release-Note:
>Audit-Trail:
>Unformatted: