ports/117192: make readmes broken

[Jörgen Blomberg]

>Number:         117192
>Category:       ports
>Synopsis:       make readmes broken
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Oct 14 20:10:00 UTC 2007
>Closed-Date:
>Last-Modified:
>Originator:     Jörgen Blomberg
>Release:        6.2-RELEASE
>Organization:
>Environment:
FreeBSD jumbo.blomberg 6.2-RELEASE FreeBSD 6.2-RELEASE #0: Tue Feb 20 19:41:57 CET 2007     root at jumbo.blomberg:/usr/obj/usr/src/sys/GENERIC  i386

>Description:
make readmes ends with this output:
..
===> x11-wm
===>  Creating README.html
===>   Creating README.html for all ports
/usr/ports/Tools/make_readmes: Permission denied
*** Error code 126

Stop in /usr/ports.


It broke sometimes around Aug 5 2007.

PERL variable seems to be undefined as indicated by this patch

--- bsd.port.subdir.mk.orig     Thu Aug  9 03:21:34 2007
+++ bsd.port.subdir.mk  Sun Oct 14 14:12:45 2007
@@ -254,6 +254,8 @@
 .if !target(readmes)
 .if defined(PORTSTOP)
 readmes: readme ${SUBDIR:S/^/_/:S/$/.readmes/}
+       @${ECHO_CMD} "Variable PERL:"
+       @${ECHO_CMD} ${PERL}
        @${ECHO_MSG} "===>   Creating README.html for all ports"
        @${PERL} ${PORTSDIR}/Tools/make_readmes < ${INDEXDIR}/${INDEXFILE}
 .else

that gives this result:

..
===> x11-wm
===>  Creating README.html
Variable PERL:

===>   Creating README.html for all ports
/usr/ports/Tools/make_readmes: Permission denied
*** Error code 126

Stop in /usr/ports.

>How-To-Repeat:
$ pwd
/usr/ports
$ make readmes
===>  Creating README.html
===> accessibility
===>  Creating README.html
===> arabic
===>  Creating README.html
..
===>  Creating README.html
===> x11-toolkits
===>  Creating README.html
===> x11-wm
===>  Creating README.html
===>   Creating README.html for all ports
/usr/ports/Tools/make_readmes: Permission denied
*** Error code 126

Stop in /usr/ports.

>Fix:
make readmes works with the attached patch. This fix is probably not usable in general, but it indicates what the problem is.


Patch attached with submission follows:

--- bsd.port.subdir.mk.orig	Thu Aug  9 03:21:34 2007
+++ bsd.port.subdir.mk	Sun Oct 14 20:23:27 2007
@@ -255,7 +255,7 @@
 .if defined(PORTSTOP)
 readmes: readme ${SUBDIR:S/^/_/:S/$/.readmes/}
 	@${ECHO_MSG} "===>   Creating README.html for all ports"
-	@${PERL} ${PORTSDIR}/Tools/make_readmes < ${INDEXDIR}/${INDEXFILE}
+	/usr/local/bin/perl ${PORTSDIR}/Tools/make_readmes < ${INDEXDIR}/${INDEXFILE}
 .else
 readmes: readme
 .endif


>Release-Note:
>Audit-Trail:
>Unformatted: