ports/117916: Mk/bsd.port.mk: Reversed condition for setting --no-same-owner in extract

[Anton Berezin]

>Number:         117916
>Category:       ports
>Synopsis:       Mk/bsd.port.mk: Reversed condition for setting --no-same-owner in extract
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Nov 08 10:00:07 UTC 2007
>Closed-Date:
>Last-Modified:
>Originator:     Anton Berezin
>Release:        FreeBSD 7.0-CURRENT amd64
>Organization:
>Environment:
System: FreeBSD heechee.tobez.org 7.0-CURRENT FreeBSD 7.0-CURRENT #3: Sun Oct 7 14:10:13 CEST 2007 root at heechee.tobez.org:/usr/obj/usr/src/sys/HEECHEE amd64


>Description:

I've got a report from Michael R. Wayne <wayne at staff.msen.com> about problems
building perl.  Specifically, he had the following errors:

  perl-5.8.8: Can't set user=1013/group=1013 for perl-5.8.8: Disc quota exceeded

repeated multiple times.  He happened to have a user with uid 1013 on his
system which was out of quota.

A little joint investigation revealed that although FreeBSD ports
infrastructure is meant to do the right thing in those conditions,
it in fact does not do that due to a reversed condition in bsd.port.mk.

>How-To-Repeat:
	
>Fix:

--- bsd.port.mk.orig	2007-11-08 10:35:04.000000000 +0100
+++ bsd.port.mk	2007-11-08 10:35:36.000000000 +0100
@@ -2221,9 +2221,9 @@ EXTRACT_AFTER_ARGS?=
 .else
 EXTRACT_BEFORE_ARGS?=	-dc
 .if defined(EXTRACT_PRESERVE_OWNERSHIP)
-EXTRACT_AFTER_ARGS?=	| ${TAR} -xf - --no-same-owner
-.else
 EXTRACT_AFTER_ARGS?=	| ${TAR} -xf -
+.else
+EXTRACT_AFTER_ARGS?=	| ${TAR} -xf - --no-same-owner
 .endif
 .if defined(USE_BZIP2)
 EXTRACT_CMD?=			${BZIP2_CMD}

>Release-Note:
>Audit-Trail:
>Unformatted: