ports/113040: [Patch]: graphics/py-imaging - respect WITHOUT_TKINTER knob

Marcus von Appen mva at sysfault.org
Sat May 26 22:10:05 UTC 2007


>Number:         113040
>Category:       ports
>Synopsis:       [Patch]: graphics/py-imaging - respect WITHOUT_TKINTER knob
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat May 26 22:10:05 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Marcus von Appen
>Release:        FreeBSD 6.2-STABLE i386
>Organization:
>Environment:
FreeBSD magenta.linden.home 6.2-STABLE FreeBSD 6.2-STABLE #0: Sat May 26 00:04:44 CEST 2007     root at magenta.linden.home:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
graphics/py-tkinter does not care about the TKINTER knob in
cases where py-tkinter is already installed.

The attached patch fixes this by explicitly deactivating the
py-tkinter checks in the setup.py of the upstream packege.

Bumped PORTREVISION in order to point users to that issue and to
allow them to get rid of the superfluous module. Maybe a small
note in UPDATING would make sense, so users delete
%%PYTHON_SITELIBDIR%%/PIL/_imagingtk.so if they do not use the
TKINTER knob.

>How-To-Repeat:

>Fix:
diff -Nur py-imaging/Makefile py-imaging.new/Makefile
--- py-imaging/Makefile	Sat May 26 23:14:00 2007
+++ py-imaging.new/Makefile	Sat May 26 23:29:36 2007
@@ -7,7 +7,7 @@
 
 PORTNAME=	imaging
 PORTVERSION=	1.1.6
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	graphics python
 MASTER_SITES=	http://effbot.org/downloads/ \
 		http://www.pythonware.net/storage/
@@ -41,6 +41,11 @@
 PLIST_SUB+=	TKINTER=""
 .else
 PLIST_SUB+=	TKINTER="@comment "
+.endif
+
+.if defined(WITHOUT_TKINTER)
+post-patch:
+	@${REINPLACE_CMD} -e 's|if _tkinter|if None|g' ${WRKSRC}/setup.py
 .endif
 
 post-install:


>Release-Note:
>Audit-Trail:
>Unformatted:



More information about the freebsd-ports-bugs mailing list