ports/113020: bad OPTIONS syntax and checks in ports/textproc/htmldoc

[Eygene Ryabinkin]

>Number:         113020
>Category:       ports
>Synopsis:       bad OPTIONS syntax and checks in ports/textproc/htmldoc
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat May 26 04:20:03 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Eygene Ryabinkin
>Release:        FreeBSD 7.0-CURRENT i386
>Organization:
Code Labs
>Environment:
System: FreeBSD XXX 7.0-CURRENT FreeBSD 7.0-CURRENT #25: Fri May 18 17:25:48 MSD 2007 root at XXX:/usr/src/sys/i386/compile/XXX i386
>Description:
* OPTIONS statements should carry 'on' or 'off'.  HTMLDOCGUI was
  using 'no'.
* One should check the WITH_/WITHOUT_ values of the opposite kind
  relative to what is told in the OPTIONS.  For the HTMLDOCGUI='off'
  WITH_HTMLDOCGUI should be checked.  See Porter Handbook for the
  explanation.
>How-To-Repeat:
Define BATCH=yes and compile the port.  It will be built with the
GUI support, but it is intended to be built without GUI by-default.
>Fix:
The following patch will go.  May be the PORTREVISION should be
bumped.

diff -ur htmldoc.orig/Makefile htmldoc/Makefile
--- htmldoc.orig/Makefile	Sat May 26 07:20:48 2007
+++ htmldoc/Makefile	Sat May 26 07:38:26 2007
@@ -19,7 +19,7 @@
 LIB_DEPENDS=	jpeg:${PORTSDIR}/graphics/jpeg	\
 		png:${PORTSDIR}/graphics/png
 
-OPTIONS=	HTMLDOCGUI "Build GUI front-end" no
+OPTIONS=	HTMLDOCGUI "Build GUI front-end" off
 # .bz2 file is available since Aug 2, but we don't want to
 # start mirroring _in addition to_ the .gz variant. When the
 # vendor's release is updated again, we should switch to .bz2
@@ -48,7 +48,7 @@
 
 .include <bsd.port.pre.mk>
 
-.if !defined(WITHOUT_HTMLDOCGUI)
+.if defined(WITH_HTMLDOCGUI)
 LIB_DEPENDS+=	fltk:${PORTSDIR}/x11-toolkits/fltk
 CONFIGURE_ARGS+=--enable-gui
 .endif
>Release-Note:
>Audit-Trail:
>Unformatted: