ports/110870: bsd.port.mk: small fix for FreeBSD 4.8 (or older versions) support

[Panagiotis Christias]

>Number:         110870
>Category:       ports
>Synopsis:       bsd.port.mk: small fix for FreeBSD 4.8 (or older versions) support
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Mar 26 16:40:04 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Panagiotis Christias
>Release:        FreeBSD 4.8
>Organization:
NTUA NOC
>Environment:
I understand that FreeBSD 4.x is no longer supported but since the solution is so simple (see attached patch file) it would be easy to include it.

>Description:
e have a dozen of old FreeBSD 4.8 boxes in production operating as transparent proxies. Trying to build any port fails:

% cd /usr/ports/www/squid 
% make
"/usr/ports/Mk/bsd.port.mk", line 2274: warning: String comparison operator should be either == or !=
"/usr/ports/Mk/bsd.port.mk", line 2274: warning: String comparison operator should be either == or !=
"/usr/ports/Mk/bsd.port.mk", line 2274: Malformed conditional (((${OSVERSION} < 504105 || (${OSVERSION} >= 600000 && ${OSVERSION} < 600103) || (${OSVERSION} >= 700000 && ${OSVERSION} < 700012)) && ${PKGORIGIN} != "ports-mgmt/pkg_install") || exists(${LOCALBASE}/sbin/pkg_info))
"/usr/ports/Mk/bsd.port.mk", line 2275: warning: String comparison operator should be either == or !=
"/usr/ports/Mk/bsd.port.mk", line 2275: warning: String comparison operator should be either == or !=
"/usr/ports/Mk/bsd.port.mk", line 2275: Malformed conditional ((${OSVERSION} < 504105 || (${OSVERSION} >= 600000 && ${OSVERSION} < 600103) || (${OSVERSION} >= 700000 && ${OSVERSION} < 700012)) && ${PKGORIGIN} != "ports-mgmt/pkg_install")
"/usr/ports/Mk/bsd.port.mk", line 2290: if-less else
"/usr/ports/Mk/bsd.port.mk", line 2290: Need an operator
"/usr/ports/Mk/bsd.port.mk", line 2304: if-less endif
"/usr/ports/Mk/bsd.port.mk", line 2304: Need an operator
"/usr/ports/Mk/bsd.port.mk", line 5947: if-less endif
"/usr/ports/Mk/bsd.port.mk", line 5947: Need an operator
make: fatal errors encountered -- cannot continue

>How-To-Repeat:
Just run "make" in any port directory of a FreeBSD 4.8 box:

% cd /usr/ports/www/squid 
% make

>Fix:
I understand that FreeBSD 4.x is no longer supported but since the solution is so simple (see attached patch file) it would be easy to include it.


Patch attached with submission follows:

--- /usr/ports/Mk/bsd.port.mk.orig	Mon Mar 26 18:10:25 2007
+++ /usr/ports/Mk/bsd.port.mk	Mon Mar 26 16:53:35 2007
@@ -2271,8 +2271,8 @@
 PKGORIGIN?=		${PKGCATEGORY}/${PORTDIRNAME}
 
 
-.if ((${OSVERSION} < 504105 || (${OSVERSION} >= 600000 && ${OSVERSION} < 600103) || (${OSVERSION} >= 700000 && ${OSVERSION} < 700012)) && ${PKGORIGIN} != "ports-mgmt/pkg_install") || exists(${LOCALBASE}/sbin/pkg_info)
-.if (${OSVERSION} < 504105 || (${OSVERSION} >= 600000 && ${OSVERSION} < 600103) || (${OSVERSION} >= 700000 && ${OSVERSION} < 700012)) && ${PKGORIGIN} != "ports-mgmt/pkg_install"
+.if ((${OSVERSION} < 504105 || (${OSVERSION} >= 600000 && ${OSVERSION} < 600103 ) || (${OSVERSION} >= 700000 && ${OSVERSION} < 700012 )) && ${PKGORIGIN} != "ports-mgmt/pkg_install") || exists(${LOCALBASE}/sbin/pkg_info)
+.if (${OSVERSION} < 504105 || (${OSVERSION} >= 600000 && ${OSVERSION} < 600103 ) || (${OSVERSION} >= 700000 && ${OSVERSION} < 700012 )) && ${PKGORIGIN} != "ports-mgmt/pkg_install"
 EXTRACT_DEPENDS+=	${LOCALBASE}/sbin/pkg_info:${PORTSDIR}/ports-mgmt/pkg_install
 .endif
 .if !defined(DESTDIR)

>Release-Note:
>Audit-Trail:
>Unformatted: