ports/110526: dkim-milter startup script not using all paramters

[Ludger Bolmerg]

>Number:         110526
>Category:       ports
>Synopsis:       dkim-milter startup script not using all paramters
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Mar 19 17:20:03 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Ludger Bolmerg
>Release:        6.2
>Organization:
>Environment:
FreeBSD bsd60.berliner.de 6.2-RELEASE-p2 FreeBSD 6.2-RELEASE-p2 #1
>Description:
the dkim-milter startup script does not reflect the settings of the following variables set in /etc/rc.conf

milterdkim_domain, milterdkim_key, milterdkim_selector, milterdkim_alg

Setting these variables has no effect
>How-To-Repeat:
set variables in /etc/rc.conf and start dkim-milter using /usr/local/etc/rc.d/milterdkim
>Fix:
here is a suggestion for a patch

--- milter-dkim-orig    Mon Mar 19 15:07:42 2007
+++ milter-dkim Mon Mar 19 15:10:58 2007
@@ -67,7 +67,7 @@
        eval milterdkim_domain="\${milterdkim_${profile}_domain:-${milterdkim_do
main}}"
        eval milterdkim_key="\${milterdkim_${profile}_key:-${milterdkim_key}}"
        eval milterdkim_flags="\${milterdkim_${profile}_flags:-${milterdkim_flag
s}}"
-       command_args="-l -p ${milterdkim_socket} -u ${milterdkim_uid} -P ${pidfi
le}"
+       command_args="-l -p ${milterdkim_socket} -u ${milterdkim_uid} -P ${pidfi
le} -d ${milterdkim_domain} -k ${milterdkim_key} -s ${milterdkim_selector} -S ${
milterdkim_alg}"
     else
        echo "$0: extra argument ignored"
     fi
@@ -90,7 +90,7 @@
        fi
     else
        milterdkim_flags=${milterdkim_flags}
-       command_args="-l -p ${milterdkim_socket} -u ${milterdkim_uid} -P ${pidfi
le}"
+       command_args="-l -p ${milterdkim_socket} -u ${milterdkim_uid} -P ${pidfi
le} -d ${milterdkim_domain} -k ${milterdkim_key} -s ${milterdkim_selector} -S ${
milterdkim_alg}"
     fi
 fi




>Release-Note:
>Audit-Trail:
>Unformatted: