ports/110108: cups-base port using killall on pre-install kills all running cups instances on host system
Dierk Sacher
usenet01 at blaxxtarz.de
Thu Mar 8 23:00:07 UTC 2007
>Number: 110108
>Category: ports
>Synopsis: cups-base port using killall on pre-install kills all running cups instances on host system
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Thu Mar 08 23:00:06 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator: Dierk Sacher
>Release: 6.2-RELEASE
>Organization:
DSITC
>Environment:
FreeBSD maxx.evangelion.free 6.2-RELEASE FreeBSD 6.2-RELEASE #0: Sat Feb 10 02:08:48 CET 2007 root at maxx.evangelion.free:/usr/obj/usr/src/sys/MAXX62 i386
>Description:
The cups-base port is using a "killall cupsd" in the pre-install target. This also kills running cupsd instances on the host system if you are doing the install in a tinderbox or other chrooted build environment other than jail(2). I understand, that there is no cupsd pidfile which could be utilized for detecting the right cupsd instance and kill only that one.
>How-To-Repeat:
setup a tinderbox or just a chroot tree. Do a make install for cups-base. If there was a cupsd running on the host of the chroot, its now killed.
>Fix:
I think the best would be the introduction of a makevar, which disables touching running instances at all. There are a lot of other ports (dhcp-server) which could use such a makevar too.
Take the attached patch against the cups-base Makefile as an example.
As there seems to be a problem with the webform (error: attached patch has wrong content type?) I'll put it here:
---------------------------------------------
--- Makefile.orig Sat Feb 10 03:22:39 2007
+++ Makefile Thu Mar 8 23:51:48 2007
@@ -142,8 +142,10 @@
${WRKSRC}/${CONFIGURE_SCRIPT}
pre-install:
+.if !defined(RUNNING_IN_CHROOT)
@${ECHO_MSG} "===>" Stopping cupsd ...
-killall cupsd || ${TRUE}
+.endif
@${INSTALL} -d ${DESKTOPDIR}/
post-install:
---------------------------------------------
>Release-Note:
>Audit-Trail:
>Unformatted:
More information about the freebsd-ports-bugs
mailing list