ports/113515: [PATCH]: Some errors in www/lynx-* with devel/ncurses installed

[Ighighi]

>Number:         113515
>Category:       ports
>Synopsis:       [PATCH]: Some errors in www/lynx-* with devel/ncurses installed
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jun 10 10:20:00 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Ighighi
>Release:        6.2-STABLE
>Organization:
>Environment:
FreeBSD orion 6.2-STABLE FreeBSD 6.2-STABLE #4: Sat Jun  2 05:22:26 VET 2007     root at orion:/usr/obj/usr/src/sys/CUSTOM  i386
>Description:
www/lynx-ssl fails to compile with devel/ncurses installed.
The respective port versions as of this time of writing are:
lynx-ssl-2.8.6_5,1
ncurses-5.6_1

The error message is as follows:
+++++ BEGIN ERROR MESSAGE

cc  -D_BSD_TYPES -D__BSD_VISIBLE -D_POSIX_C_SOURCE=200112L -D_XOPEN_SOURCE=600 -DHAVE_CONFIG_H   -DLOCALEDIR=\"/usr/local/share/locale\"  -I.  -I..  -Ichrtrans  -I./chrtrans  -I..  -I../src  -I../WWW/Library/Implementation    -O -pipe -I/usr/local/include -c ./LYStrings.c
./LYStrings.c: In function `expand_tiname':
./LYStrings.c:953: error: `strnames' undeclared (first use in this function)
./LYStrings.c:953: error: (Each undeclared identifier is reported only once
./LYStrings.c:953: error: for each function it appears in.)
./LYStrings.c:954: error: `strfnames' undeclared (first use in this function)
./LYStrings.c:955: error: `cur_term' undeclared (first use in this function)
*** Error code 1

Stop in /usr/ports/www/lynx-ssl/work/lynx2-8-6/src.
*** Error code 1

Stop in /usr/ports/www/lynx-ssl/work/lynx2-8-6.
*** Error code 1

Stop in /usr/ports/www/lynx-ssl.

+++++ END ERROR MESSAGE

A little inspection revealed to me that the configure mechanism in lynx is
accessing the /usr/local/include/ncurses/* files installed by devel/ncurses
as a side-effect of "-I/usr/local/include", as shown by a diff on the output
of "make configure" when devel/ncurses is available and unavailable, resp.

124c124
< checking for ncurses header in include-path... ncurses/ncurses.h
---
> checking for ncurses header in include-path... curses.h

It is worth noting that www/lynx-current builds perfectly, maybe because their
configure mechanism was corrected.

In my opinion there should be a knob in www/lynx* to allow optional linkage with
devel/ncurses, at least for www/lynx-current since the latter always tries to
use the version in ports first, unlike www/lynx and www/lynx-ssl, thus making
devel/ncurses a dependency.
>How-To-Repeat:

>Fix:
The attached patch deletes the following line in /usr/ports/www/lynx-ssl/work/lynx2-8-6/config.hin

#undef HAVE_NCURSES_NCURSES_H  /* defined if we include <ncurses/ncurses.h> */


Patch attached with submission follows:

--- config.hin.orig	Mon Oct  2 15:56:53 2006
+++ config.hin	Sun Jun 10 05:18:11 2007
@@ -102,7 +102,6 @@
 #undef HAVE_NCURSESW_NCURSES_H	/* defined if we include <ncursesw/ncurses.h> */
 #undef HAVE_NCURSESW_TERM_H	/* have <ncursesw/term.h> */
 #undef HAVE_NCURSES_H		/* defined if we include <ncurses.h> */
-#undef HAVE_NCURSES_NCURSES_H	/* defined if we include <ncurses/ncurses.h> */
 #undef HAVE_NCURSES_TERM_H	/* have <ncurses/term.h> */
 #undef HAVE_NEWPAD
 #undef HAVE_NEWTERM


>Release-Note:
>Audit-Trail:
>Unformatted: