ports/114366: [patch] x11/slim causes 'getty repeating too quickly'

[Nikos Ntarmos]

>Number:         114366
>Category:       ports
>Synopsis:       [patch] x11/slim causes 'getty repeating too quickly'
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jul 06 18:50:06 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Nikos Ntarmos
>Release:        FreeBSD 7.0-CURRENT i386
>Organization:
NetCInS Lab., C.E.I.D., U. of Patras, Greece
>Environment:
System: FreeBSD ace.b020.ceid.upatras.gr 7.0-CURRENT FreeBSD 7.0-CURRENT #2: Wed Jul 4 07:21:29 EEST 2007 ntarmos at ace.b020.ceid.upatras.gr:/opt/obj/opt/src/sys/ACE i386


	
>Description:
x11/slim is a X11 login manager. When used as the default desktop
manager through /etc/ttys the login screen comes up ok but init emits a
stream of 'getty repeating too quickly' for the corresponding terminal.
This is due to the use of an uninitialized boolean variable
('daemonmode'); with gcc optimization above O0 the memory allocated via
'new' is not zeroed out, thus 'daemonmode' defaults to values other than
0. Furthermore, the code only checks for equality with 'false', thus
x11/slim enters daemon mode by default, hence the 'getty...' error
stream. This is with both gcc 4.2.x on 7-CURRENT and 3.4.x on 6-STABLE.
	
>How-To-Repeat:
Install x11/slim and use it as a desktop manager through /etc/ttys.
	
>Fix:

	

--- patch-app.cpp-daemonmode begins here ---
--- app.cpp.orig	2007-07-06 17:04:22.000000000 +0300
+++ app.cpp	2007-07-06 20:17:33.000000000 +0300
@@ -59,6 +59,7 @@
     ServerPID = -1;
     testing = false;
     mcookie = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
+	   daemonmode = false;
 
     // Parse command line
     while((tmp = getopt(argc, argv, "vhp:d?")) != EOF) {
--- patch-app.cpp-daemonmode ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted: