ports/114280: Port security/libssh2 uses wrong linker flags

[Sven Berkvens-Matthijsse]

>Number:         114280
>Category:       ports
>Synopsis:       Port security/libssh2 uses wrong linker flags
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jul 04 07:50:03 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Sven Berkvens-Matthijsse
>Release:        FreeBSD 6.2-STABLE i386
>Organization:
ilse media BV
>Environment:
System: FreeBSD serv6.ilse.nl 6.2-STABLE FreeBSD 6.2-STABLE #0: Fri Jun 1 13:58:11 CEST 2007 root at serv6.ilse.nl:/usr/obj/usr/src/sys/SERV6 i386
>Description:
	The security/libssh2 port uses incorrect linker flags, causing it
	to have the following substring in the linker flags:

		-L-L/usr/local/lib

	And thus, this port will link to /usr/lib/libcrypto.so.4 instead of
	/usr/local/lib/libcrypto.so.5 if the security/openssl port is
	installed.

	The side-effect of this is that if security/openssl port is installed,
	which most packages link against instead of the system's libraries in
	/usr/lib, and they use libssh2 as well, that both
	/usr/lib/libcrypto.so.4 and /usr/local/lib/libcrypto.so.5 will be
	linked into the program, causing disaster.

>How-To-Repeat:
	Install security/openssl, then security/libssh2, then ftp/curl. The
	curl library now link against both libcrypto.so.4 and libcrypto.so.5.

>Fix:
	The patch-configure file in security/libssh2/files is incorrect! It
	should NOT prefix the output of "pkg-config --libs openssl" with -L,
	the -L is already included!

>Release-Note:
>Audit-Trail:
>Unformatted: