ffmpeg-devel port's Makefile can corrupt makefile's (ports/104427)

[Siavosh Benabbas]

Hello All,
I filed this http://www.freebsd.org/cgi/query-pr.cgi?pr=104427 PR some
time ago but it was never fixed/closed. I don't know if this is the
right list but I will post it anyway. Sorry for cross posting.

Basically the ffmpeg-devel port's Makefile has a ${REINPLACE_CMD} line

                         ${REINPLACE_CMD} -E \
                         -e 's@^(CFLAGS.+)$$@\1 ${FFMPEG_CFLAGS}@' \
                         -e 's@^(FFLIBS|LDFLAGS)(.+)$$@\1\2 ${FFMPEG_LDFLAGS}@'

This would corrupt the Makefile if a CFLAGS assignment is split over
multiple lines using \ at the end of the lines. These long assignments
are present in new ffmpeg sources (the current ffmpeg-devel port is
very outdated). I have also posted a patch which brings all such lines
to the sed pattern space and fixes the problem, it is attached.

Please CC me as I am not on the list.
Thanks,
Siavosh Benabbas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-1.diff
Type: text/x-patch
Size: 447 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/attachments/20070224/367c1613/attachment.bin>