ports/109090: ports/news/tin overwrites existing scripts, installs "bashed" scripts

[clemens fischer]

>Number:         109090
>Category:       ports
>Synopsis:       ports/news/tin overwrites existing scripts, installs "bashed" scripts
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Feb 12 15:30:03 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     clemens fischer
>Release:        FreeBSD 6.2-STABLE i386
>Organization:
>Environment:

System: FreeBSD spotteswoode.dnsalias.org 6.2-STABLE
FreeBSD 6.2-STABLE #15: Tue Feb 6 17:34:47 CET 2007
root at spotteswoode.dnsalias.org:/usr/obj/usr/src/sys/spott i386

>Description:

the ports/news/tin upstream tarball contains a number of scripts
ins "./tools/" directory. some of them get installed without
checking. in particular, even when defining "WITHOUT_TIN_METAMAIL",
a script called "url_handler.sh" is installed, overwriting one from
ports/textproc/urlview. furthermore, the tin version is much inferior,
as commands to handle specific URL schemes ("netscape" for http in a
ncurses-application?!) are hardwired. some perl scripts are installed
without adding perl to RUN_DEPENDS. all scripts have shebang lines from
the linux world: they contain "/usr/bin/" as the command prefix.

the net result of all this:  installed commands cease to work, the tin
versions don't run on freebsd without tweaking.

every time tin gets updated, i have to fix "url_handler.sh"!

>How-To-Repeat:

after installing tin, try other applications using "url_handler.sh", or
try any other tin-tools.

>Fix:

as there are RUN_DEPENDS lines for, eg. "metamail", which satisfy
tin requirements, tin must not install its tools version of, eg.
"url_handler.sh". instead, install those tools into local/libexec/tin/
or local/share/tin/, but make sure the shebang paths are correct.  i,
for one, have never used or needed any of the tools.

also, do not install tools explicitly not wanted by the user specifying
"WITHOUT_*" options.
>Release-Note:
>Audit-Trail:
>Unformatted: